chore(deps): update vitest monorepo to v5 (#31912)

Co-authored-by: Daniel Dietzler <mail@ddietzler.dev>

e2e/package.json

@@ -55,6 +55,6 @@
     "typescript": "npm:@typescript/typescript6@^6.0.2",
     "typescript-eslint": "^8.28.0",
     "utimes": "^5.2.1",
-    "vitest": "^4.0.0"
+    "vitest": "^5.0.0"
   }
 }

e2e/src/specs/maintenance/server/database-backups.e2e-spec.ts

@@ -91,7 +91,7 @@ describe('/admin/database-backups', () => {
 
   // => action: restore database flow
 
-  describe.sequential('POST /start-restore', () => {
+  describe('POST /start-restore', { concurrent: false }, () => {
     afterAll(async () => {
       await request(app).post('/admin/maintenance').set('cookie', cookie!).send({ action: 'end' });
       await utils.poll(
@@ -104,14 +104,14 @@ describe('/admin/database-backups', () => {
       });
     });
 
-    it.sequential('should not work when the server is configured', async () => {
+    it('should not work when the server is configured', { concurrent: false }, async () => {
       const { status, body } = await request(app).post('/admin/database-backups/start-restore').send();
 
       expect(status).toBe(400);
       expect(body).toEqual(errorDto.badRequest('Admin setup is not available'));
     });
 
-    it.sequential('should enter maintenance mode in "database restore mode"', async () => {
+    it('should enter maintenance mode in "database restore mode"', { concurrent: false }, async () => {
       await utils.resetDatabase(); // reset database before running this test
 
       const { status, headers } = await request(app).post('/admin/database-backups/start-restore').send();
@@ -145,7 +145,7 @@ describe('/admin/database-backups', () => {
 
   // => action: restore database
 
-  describe.sequential('POST /backups/restore', () => {
+  describe('POST /backups/restore', { concurrent: false }, () => {
     beforeAll(async () => {
       await utils.disconnectDatabase();
     });
@@ -154,7 +154,7 @@ describe('/admin/database-backups', () => {
       await utils.connectDatabase();
     });
 
-    it.sequential('should restore a backup', { timeout: 60_000 }, async () => {
+    it('should restore a backup', { timeout: 60_000, concurrent: false }, async () => {
       let filename = await utils.createBackup(admin.accessToken);
 
       // work-around until test is running on released version
@@ -212,7 +212,7 @@ describe('/admin/database-backups', () => {
         .toBeFalsy();
     });
 
-    it.sequential('fail to restore a corrupted backup', { timeout: 60_000 }, async () => {
+    it('fail to restore a corrupted backup', { timeout: 60_000, concurrent: false }, async () => {
       await utils.prepareTestBackup('corrupted');
 
       const { status, headers } = await request(app)
@@ -283,7 +283,7 @@ describe('/admin/database-backups', () => {
       );
     });
 
-    it.sequential('rollback to restore point if backup is missing admin', { timeout: 60_000 }, async () => {
+    it('rollback to restore point if backup is missing admin', { timeout: 60_000, concurrent: false }, async () => {
       await utils.prepareTestBackup('empty');
 
       const { status, headers } = await request(app)

e2e/src/specs/maintenance/server/maintenance.e2e-spec.ts

@@ -45,7 +45,7 @@ describe('/admin/maintenance', () => {
 
   // => enter maintenance mode
 
-  describe.sequential('POST /', () => {
+  describe('POST /', { concurrent: false }, () => {
     it('should be a no-op if try to exit maintenance mode', async () => {
       const { status } = await request(app)
         .post('/admin/maintenance')
@@ -87,7 +87,7 @@ describe('/admin/maintenance', () => {
 
   // => in maintenance mode
 
-  describe.sequential('in maintenance mode', () => {
+  describe('in maintenance mode', { concurrent: false }, () => {
     describe('GET ~/server/config', async () => {
       it('should indicate we are in maintenance mode', async () => {
         const { status, body } = await request(app).get('/server/config');
@@ -152,7 +152,7 @@ describe('/admin/maintenance', () => {
 
   // => exit maintenance mode
 
-  describe.sequential('POST /', () => {
+  describe('POST /', { concurrent: false }, () => {
     it('should exit maintenance mode', async () => {
       const { status } = await request(app).post('/admin/maintenance').set('cookie', cookie!).send({
         action: 'end',

e2e/src/specs/server/api/integrity.e2e-spec.ts

@@ -96,7 +96,7 @@ describe('/admin/integrity', () => {
   });
 
   describe('POST /summary (& jobs)', async () => {
-    it.sequential('reports no issues', async () => {
+    it('reports no issues', { concurrent: false }, async () => {
       await utils.createJob(admin.accessToken, {
         name: ManualJobName.IntegrityUntrackedFiles,
       });
@@ -130,7 +130,7 @@ describe('/admin/integrity', () => {
       });
     });
 
-    it.sequential('should detect an untracked file (job: check untracked files)', async () => {
+    it('should detect an untracked file (job: check untracked files)', { concurrent: false }, async () => {
       await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {
@@ -152,31 +152,35 @@ describe('/admin/integrity', () => {
       );
     });
 
-    it.sequential('should detect outdated untracked file reports (job: refresh untracked files)', async () => {
-      // these should not be detected:
-      await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked2.png`);
-      await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked3.png`);
+    it(
+      'should detect outdated untracked file reports (job: refresh untracked files)',
+      { concurrent: false },
+      async () => {
+        // these should not be detected:
+        await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked2.png`);
+        await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked3.png`);
 
-      await utils.createJob(admin.accessToken, {
-        name: ManualJobName.IntegrityUntrackedFilesRefresh,
-      });
+        await utils.createJob(admin.accessToken, {
+          name: ManualJobName.IntegrityUntrackedFilesRefresh,
+        });
 
-      await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
+        await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
 
-      const { status, body } = await request(app)
-        .get('/admin/integrity/summary')
-        .set('Authorization', `Bearer ${admin.accessToken}`)
-        .send();
+        const { status, body } = await request(app)
+          .get('/admin/integrity/summary')
+          .set('Authorization', `Bearer ${admin.accessToken}`)
+          .send();
 
-      expect(status).toBe(200);
-      expect(body).toEqual(
-        expect.objectContaining({
-          untracked_file: 0,
-        }),
-      );
-    });
+        expect(status).toBe(200);
+        expect(body).toEqual(
+          expect.objectContaining({
+            untracked_file: 0,
+          }),
+        );
+      },
+    );
 
-    it.sequential('should delete untracked files (job: delete all untracked file reports)', async () => {
+    it('should delete untracked files (job: delete all untracked file reports)', { concurrent: false }, async () => {
       await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {
@@ -204,30 +208,34 @@ describe('/admin/integrity', () => {
       );
     });
 
-    it.sequential('should detect a missing file and not a checksum mismatch (job: check missing files)', async () => {
-      await utils.deleteFolder(`/data/upload/${admin.userId}`);
+    it(
+      'should detect a missing file and not a checksum mismatch (job: check missing files)',
+      { concurrent: false },
+      async () => {
+        await utils.deleteFolder(`/data/upload/${admin.userId}`);
 
-      await utils.createJob(admin.accessToken, {
-        name: ManualJobName.IntegrityMissingFiles,
-      });
+        await utils.createJob(admin.accessToken, {
+          name: ManualJobName.IntegrityMissingFiles,
+        });
 
-      await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
+        await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
 
-      const { status, body } = await request(app)
-        .get('/admin/integrity/summary')
-        .set('Authorization', `Bearer ${admin.accessToken}`)
-        .send();
+        const { status, body } = await request(app)
+          .get('/admin/integrity/summary')
+          .set('Authorization', `Bearer ${admin.accessToken}`)
+          .send();
 
-      expect(status).toBe(200);
-      expect(body).toEqual(
-        expect.objectContaining({
-          missing_file: 1,
-          checksum_mismatch: 0,
-        }),
-      );
-    });
+        expect(status).toBe(200);
+        expect(body).toEqual(
+          expect.objectContaining({
+            missing_file: 1,
+            checksum_mismatch: 0,
+          }),
+        );
+      },
+    );
 
-    it.sequential('should detect outdated missing file reports (job: refresh missing files)', async () => {
+    it('should detect outdated missing file reports (job: refresh missing files)', { concurrent: false }, async () => {
       await utils.createJob(admin.accessToken, {
         name: ManualJobName.IntegrityMissingFilesRefresh,
       });
@@ -248,53 +256,57 @@ describe('/admin/integrity', () => {
       );
     });
 
-    it.sequential('should delete assets with missing files (job: delete all missing file reports)', async () => {
-      await utils.deleteFolder(`/data/upload/${user1.userId}`);
+    it(
+      'should delete assets with missing files (job: delete all missing file reports)',
+      { concurrent: false },
+      async () => {
+        await utils.deleteFolder(`/data/upload/${user1.userId}`);
 
-      await utils.createJob(admin.accessToken, {
-        name: ManualJobName.IntegrityMissingFiles,
-      });
+        await utils.createJob(admin.accessToken, {
+          name: ManualJobName.IntegrityMissingFiles,
+        });
 
-      await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
+        await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
 
-      const { status: listStatus, body: listBody } = await request(app)
-        .get('/admin/integrity/summary')
-        .set('Authorization', `Bearer ${admin.accessToken}`)
-        .send();
+        const { status: listStatus, body: listBody } = await request(app)
+          .get('/admin/integrity/summary')
+          .set('Authorization', `Bearer ${admin.accessToken}`)
+          .send();
 
-      expect(listStatus).toBe(200);
-      expect(listBody).toEqual(
-        expect.objectContaining({
-          missing_file: 1,
-        }),
-      );
+        expect(listStatus).toBe(200);
+        expect(listBody).toEqual(
+          expect.objectContaining({
+            missing_file: 1,
+          }),
+        );
 
-      await utils.createJob(admin.accessToken, {
-        name: ManualJobName.IntegrityMissingFilesDeleteAll,
-      });
+        await utils.createJob(admin.accessToken, {
+          name: ManualJobName.IntegrityMissingFilesDeleteAll,
+        });
 
-      await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
+        await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
 
-      const { status, body } = await request(app)
-        .get('/admin/integrity/summary')
-        .set('Authorization', `Bearer ${admin.accessToken}`)
-        .send();
+        const { status, body } = await request(app)
+          .get('/admin/integrity/summary')
+          .set('Authorization', `Bearer ${admin.accessToken}`)
+          .send();
 
-      expect(status).toBe(200);
-      expect(body).toEqual(
-        expect.objectContaining({
-          missing_file: 0,
-        }),
-      );
+        expect(status).toBe(200);
+        expect(body).toEqual(
+          expect.objectContaining({
+            missing_file: 0,
+          }),
+        );
 
-      await expect(utils.getAssetInfo(user1.accessToken, asset1.id)).resolves.toEqual(
-        expect.objectContaining({
-          isTrashed: true,
-        }),
-      );
-    });
+        await expect(utils.getAssetInfo(user1.accessToken, asset1.id)).resolves.toEqual(
+          expect.objectContaining({
+            isTrashed: true,
+          }),
+        );
+      },
+    );
 
-    it.sequential('should detect a checksum mismatch (job: check file checksums)', async () => {
+    it('should detect a checksum mismatch (job: check file checksums)', { concurrent: false }, async () => {
       await utils.truncateFolder(`/data/upload/${admin.userId}`);
 
       await utils.createJob(admin.accessToken, {
@@ -316,28 +328,33 @@ describe('/admin/integrity', () => {
       );
     });
 
-    it.sequential('should detect outdated checksum mismatch reports (job: refresh file checksums)', async () => {
-      await utils.createJob(admin.accessToken, {
-        name: ManualJobName.IntegrityChecksumMismatchRefresh,
-      });
+    it(
+      'should detect outdated checksum mismatch reports (job: refresh file checksums)',
+      { concurrent: false },
+      async () => {
+        await utils.createJob(admin.accessToken, {
+          name: ManualJobName.IntegrityChecksumMismatchRefresh,
+        });
 
-      await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
+        await utils.waitForQueueFinish(admin.accessToken, QueueName.IntegrityCheck);
 
-      const { status, body } = await request(app)
-        .get('/admin/integrity/summary')
-        .set('Authorization', `Bearer ${admin.accessToken}`)
-        .send();
+        const { status, body } = await request(app)
+          .get('/admin/integrity/summary')
+          .set('Authorization', `Bearer ${admin.accessToken}`)
+          .send();
 
-      expect(status).toBe(200);
-      expect(body).toEqual(
-        expect.objectContaining({
-          checksum_mismatch: 0,
-        }),
-      );
-    });
+        expect(status).toBe(200);
+        expect(body).toEqual(
+          expect.objectContaining({
+            checksum_mismatch: 0,
+          }),
+        );
+      },
+    );
 
-    it.sequential(
+    it(
       'should delete assets with mismatched checksum (job: delete all checksum mismatch reports)',
+      { concurrent: false },
       async () => {
         await utils.truncateFolder(`/data/upload/${user2.userId}`);
 
@@ -387,7 +404,7 @@ describe('/admin/integrity', () => {
   });
 
   describe('POST /report', async () => {
-    it.sequential('reports untracked files', async () => {
+    it('reports untracked files', { concurrent: false }, async () => {
       await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {
@@ -417,7 +434,7 @@ describe('/admin/integrity', () => {
       });
     });
 
-    it.sequential('reports missing files', async () => {
+    it('reports missing files', { concurrent: false }, async () => {
       await utils.deleteFolder(`/data/upload/${admin.userId}`);
 
       await utils.createJob(admin.accessToken, {
@@ -447,7 +464,7 @@ describe('/admin/integrity', () => {
       });
     });
 
-    it.sequential('reports checksum mismatched files', async () => {
+    it('reports checksum mismatched files', { concurrent: false }, async () => {
       await utils.truncateFolder(`/data/upload/${admin.userId}`);
 
       await utils.createJob(admin.accessToken, {
@@ -479,7 +496,7 @@ describe('/admin/integrity', () => {
   });
 
   describe('DELETE /report/:id', async () => {
-    it.sequential('delete untracked files', async () => {
+    it('delete untracked files', { concurrent: false }, async () => {
       await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {
@@ -529,7 +546,7 @@ describe('/admin/integrity', () => {
       );
     });
 
-    it.sequential('delete assets missing files', async () => {
+    it('delete assets missing files', { concurrent: false }, async () => {
       await utils.deleteFolder(`/data/upload/${admin.userId}`);
 
       await utils.createJob(admin.accessToken, {
@@ -570,7 +587,7 @@ describe('/admin/integrity', () => {
       expect(listBody2.items.length).toBe(0);
     });
 
-    it.sequential('delete assets with failing checksum', async () => {
+    it('delete assets with failing checksum', { concurrent: false }, async () => {
       await utils.truncateFolder(`/data/upload/${admin.userId}`);
 
       await utils.createJob(admin.accessToken, {
@@ -613,7 +630,7 @@ describe('/admin/integrity', () => {
   });
 
   describe('GET /report/:type/csv', () => {
-    it.sequential('exports untracked files as csv', async () => {
+    it('exports untracked files as csv', { concurrent: false }, async () => {
       await utils.putTextFile('untracked', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {
@@ -637,7 +654,7 @@ describe('/admin/integrity', () => {
   });
 
   describe('GET /report/:id/file', () => {
-    it.sequential('downloads untracked file', async () => {
+    it('downloads untracked file', { concurrent: false }, async () => {
       await utils.putTextFile('untracked-content', `/data/upload/${admin.userId}/untracked1.png`);
 
       await utils.createJob(admin.accessToken, {

e2e/src/specs/web/auth.e2e-spec.ts

@@ -27,7 +27,7 @@ test.describe('Registration', () => {
     await expect(page).toHaveTitle(/Login/);
     await page.goto('/auth/login?autoLaunch=0');
     await page.getByLabel('Email').fill('admin@immich.app');
-    await page.getByLabel('Password').fill('password');
+    await page.getByLabel('Password', { exact: true }).fill('password');
     await page.getByRole('button', { name: 'Login' }).click();
 
     // onboarding

e2e/src/specs/web/shared-link.e2e-spec.ts

@@ -80,7 +80,7 @@ test.describe('Shared Links', () => {
     const input = page.getByPlaceholder('Password');
     await input.fill('test-password');
     await page.getByRole('button', { name: 'Show password' }).click();
-    // await page.getByText('test-password', { exact: true }).waitFor();
+    // await page.getByText('test-password').waitFor();
     await expect(input).toHaveAttribute('type', 'text');
   });
 

e2e/src/ui/specs/timeline/timeline.e2e-spec.ts

@@ -494,7 +494,7 @@ test.describe('Timeline', () => {
         force: false,
         ids: [assetToTrash.id],
       });
-      await page.getByText('Trash', { exact: true }).click();
+      await page.getByRole('link', { name: 'Trash' }).click();
       await thumbnailUtils.expectInViewport(page, assetToTrash.id);
       await thumbnailUtils.withAssetId(page, assetToTrash.id).hover();
       await thumbnailUtils.selectButton(page, assetToTrash.id).click();
@@ -507,12 +507,12 @@ test.describe('Timeline', () => {
           json: { count: requestJson.ids.length },
         });
       });
-      await page.getByText('Restore', { exact: true }).click();
+      await page.getByText('Restore').click();
       await expect(restoreRequest).resolves.toEqual({
         ids: [assetToTrash.id],
       });
       await expect(thumbnailUtils.withAssetId(page, assetToTrash.id)).toHaveCount(0);
-      await page.getByText('Photos', { exact: true }).click();
+      await page.getByRole('link', { name: 'Photos' }).click();
       await thumbnailUtils.expectInViewport(page, assetToTrash.id);
     });
     test('open album, trash photo, open /trash, restore', async ({ page }) => {
@@ -537,7 +537,7 @@ test.describe('Timeline', () => {
         ids: [assetToTrash.id],
       });
       await page.locator('#control-bar').getByLabel('Close').click();
-      await page.getByText('Trash', { exact: true }).click();
+      await page.getByRole('link', { name: 'Trash' }).click();
       await timelineUtils.waitForTimelineLoad(page);
       await thumbnailUtils.expectInViewport(page, assetToTrash.id);
       await thumbnailUtils.withAssetId(page, assetToTrash.id).hover();
@@ -551,7 +551,7 @@ test.describe('Timeline', () => {
           json: { count: requestJson.ids.length },
         });
       });
-      await page.getByText('Restore', { exact: true }).click();
+      await page.getByText('Restore').click();
       await expect(restoreRequest).resolves.toEqual({
         ids: [assetToTrash.id],
       });
@@ -603,7 +603,7 @@ test.describe('Timeline', () => {
         ids: [assetToArchive.id],
       });
       await expect(thumbnailUtils.withAssetId(page, assetToArchive.id)).toHaveCount(0);
-      await page.getByText('Photos', { exact: true }).click();
+      await page.getByRole('link', { name: 'Photos' }).click();
       await thumbnailUtils.expectInViewport(page, assetToArchive.id);
     });
     test('open /archive, favorite photo, unfavorite', async ({ page }) => {
@@ -749,7 +749,7 @@ test.describe('Timeline', () => {
         ids: [assetToFavorite.id],
       });
       await expect(thumbnailUtils.withAssetId(page, assetToFavorite.id)).toHaveCount(0);
-      await page.getByText('Photos', { exact: true }).click();
+      await page.getByRole('link', { name: 'Photos' }).click();
       await thumbnailUtils.expectInViewport(page, assetToFavorite.id);
     });
     test.skip('open /favorites, archive photo, unarchive photo', async ({ page }) => {