diff --git a/web/src/lib/components/shared-components/Combobox.svelte b/web/src/lib/components/shared-components/Combobox.svelte index 5db911fd5..d105b49e2 100644 --- a/web/src/lib/components/shared-components/Combobox.svelte +++ b/web/src/lib/components/shared-components/Combobox.svelte @@ -22,7 +22,6 @@
diff --git a/web/src/lib/elements/GroupTab.svelte b/web/src/lib/elements/GroupTab.svelte index 9e45805eb..8c75174e0 100644 --- a/web/src/lib/elements/GroupTab.svelte +++ b/web/src/lib/elements/GroupTab.svelte @@ -1,6 +1,4 @@
import { focusOutside } from '#lib/actions/focus-outside.ts'; import { shortcuts } from '#lib/actions/shortcut.ts'; - import { generateId } from '#lib/utils/generate-id.ts'; import { Icon } from '@immich/ui'; import { mdiStar, mdiStarOutline } from '@mdi/js'; import { t } from 'svelte-i18n'; export type Rating = -1 | 1 | 2 | 3 | 4 | 5 | null; - interface Props { + type Props = { count?: number; rating: Rating; readOnly?: boolean; onRating: (rating: Rating) => void | undefined; - } + }; - let { count = 5, rating, readOnly = false, onRating }: Props = $props(); + const { count = 5, rating, readOnly = false, onRating }: Props = $props(); let ratingSelection = $derived(rating); let hoverRating: Rating = $state(null); let focusRating: Rating = $state(null); let timeoutId: ReturnType | undefined; - const id = generateId(); + const id = $props.id(); const handleSelect = (newRating: Rating) => { if (readOnly) { diff --git a/web/src/lib/utils/generate-id.ts b/web/src/lib/utils/generate-id.ts deleted file mode 100644 index 466be1840..000000000 --- a/web/src/lib/utils/generate-id.ts +++ /dev/null @@ -1,2 +0,0 @@ -let _count = 0; -export const generateId = (): string => `id-${_count++}`; diff --git a/web/src/routes/(user)/workflows/[workflowId]/+page.svelte b/web/src/routes/(user)/workflows/[workflowId]/+page.svelte index 982435126..cb25a19d4 100644 --- a/web/src/routes/(user)/workflows/[workflowId]/+page.svelte +++ b/web/src/routes/(user)/workflows/[workflowId]/+page.svelte @@ -7,7 +7,6 @@ import { getWorkflowQuery, updateWorkflowMutation } from '#lib/queries/workflow.query.ts'; import { Route } from '#lib/route.ts'; import { getWorkflowActions } from '#lib/services/workflow.service.ts'; - import { generateId } from '#lib/utils/generate-id.ts'; import { getTriggerDescription, getTriggerName } from '#lib/utils/workflow.ts'; import type { WorkflowUpdateDto } from '@immich/sdk'; import { @@ -63,6 +62,9 @@ const query = createPreloadedQuery(() => getWorkflowQuery(params.workflowId)); const workflow = $derived(query.data); + let stepCounter = 0; + const generateId = () => `step-${stepCounter++}`; + let { id, enabled, name, description, trigger } = $state(query.data); let steps = $state(query.data.steps.map((step) => ({ ...step, id: generateId() }))); const savedWorkflow = $derived(cloneDeep(workflow));