From 27ccbee82dd88293d1648ecac0fa01ae5d18fa19 Mon Sep 17 00:00:00 2001
From: Mees Frensel <33722705+meesfrensel@users.noreply.github.com>
Date: Tue, 27 Oct 2026 15:41:59 +0100
Subject: [PATCH] refactor(web): use svelte builtin id generator (#32631)

(cherry picked from commit 285552785f1bd7cb5ad431c8b3423d1d5e858188)
---
 .../lib/components/shared-components/Combobox.svelte |  6 +-----
 .../shared-components/CoordinatesInput.svelte        |  3 +--
 .../context-menu/ButtonContextMenu.svelte            |  3 +--
 .../shared-components/context-menu/MenuOption.svelte |  6 ++----
 .../shared-components/search-bar/SearchBar.svelte    |  5 +----
 .../shared-components/settings/SettingSwitch.svelte  | 12 +++++-------
 web/src/lib/elements/GroupTab.svelte                 |  6 ++----
 web/src/lib/elements/StarRating.svelte               |  9 ++++-----
 web/src/lib/utils/generate-id.ts                     |  2 --
 .../(user)/workflows/[workflowId]/+page.svelte       |  4 +++-
 10 files changed, 20 insertions(+), 36 deletions(-)
 delete mode 100644 web/src/lib/utils/generate-id.ts

diff --git a/web/src/lib/components/shared-components/Combobox.svelte b/web/src/lib/components/shared-components/Combobox.svelte
index 5db911fd5..d105b49e2 100644
--- a/web/src/lib/components/shared-components/Combobox.svelte
+++ b/web/src/lib/components/shared-components/Combobox.svelte
@@ -22,7 +22,6 @@
 <script lang="ts">
   import { focusOutside } from '#lib/actions/focus-outside.ts';
   import { shortcuts } from '#lib/actions/shortcut.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { Icon, IconButton, Label } from '@immich/ui';
   import { mdiChevronDown, mdiClose, mdiMagnify } from '@mdi/js';
   import { onMount, tick } from 'svelte';
@@ -62,10 +61,6 @@
     forceFocus = false,
   }: Props = $props();
 
-  /**
-   * Unique identifier for the combobox.
-   */
-  let id: string = generateId();
   /**
    * Indicates whether or not the dropdown autocomplete list should be visible.
    */
@@ -80,6 +75,7 @@
   let input = $state<HTMLInputElement>();
   let bounds: DOMRect | undefined = $state();
 
+  const id = $props.id();
   const inputId = `combobox-${id}`;
   const listboxId = `listbox-${id}`;
   /**
diff --git a/web/src/lib/components/shared-components/CoordinatesInput.svelte b/web/src/lib/components/shared-components/CoordinatesInput.svelte
index 83d9bd46d..d919e4724 100644
--- a/web/src/lib/components/shared-components/CoordinatesInput.svelte
+++ b/web/src/lib/components/shared-components/CoordinatesInput.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
   import NumberRangeInput from '#lib/components/shared-components/NumberRangeInput.svelte';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { convert } from 'geo-coordinates-parser';
   import { t } from 'svelte-i18n';
 
@@ -12,7 +11,7 @@
 
   let { lat = $bindable(), lng = $bindable(), onUpdate }: Props = $props();
 
-  const id = generateId();
+  const id = $props.id();
 
   const onInput = () => {
     if (lat !== undefined && lng !== undefined) {
diff --git a/web/src/lib/components/shared-components/context-menu/ButtonContextMenu.svelte b/web/src/lib/components/shared-components/context-menu/ButtonContextMenu.svelte
index 5a469df68..a58343d7a 100644
--- a/web/src/lib/components/shared-components/context-menu/ButtonContextMenu.svelte
+++ b/web/src/lib/components/shared-components/context-menu/ButtonContextMenu.svelte
@@ -9,7 +9,6 @@
     getContextMenuPositionFromEvent,
     type Align,
   } from '#lib/utils/context-menu.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { IconButton, type Color, type Size, type Variants } from '@immich/ui';
   import type { Snippet } from 'svelte';
   import type { HTMLAttributes } from 'svelte/elements';
@@ -61,7 +60,7 @@
   let menuContainer: HTMLUListElement | undefined = $state();
   let buttonContainer: HTMLDivElement | undefined = $state();
 
-  const id = generateId();
+  const id = $props.id();
   const buttonId = `context-menu-button-${id}`;
   const menuId = `context-menu-${id}`;
 
diff --git a/web/src/lib/components/shared-components/context-menu/MenuOption.svelte b/web/src/lib/components/shared-components/context-menu/MenuOption.svelte
index f8c9de7bd..769bb75a8 100644
--- a/web/src/lib/components/shared-components/context-menu/MenuOption.svelte
+++ b/web/src/lib/components/shared-components/context-menu/MenuOption.svelte
@@ -2,7 +2,6 @@
   import type { Shortcut } from '#lib/actions/shortcut.ts';
   import { shortcut as bindShortcut, shortcutLabel as computeShortcutLabel } from '#lib/actions/shortcut.ts';
   import { optionClickCallbackStore, selectedIdStore } from '#lib/stores/context-menu.store.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { Icon, type IconLike } from '@immich/ui';
 
   interface Props {
@@ -27,9 +26,8 @@
     shortcutLabel = '',
   }: Props = $props();
 
-  let id: string = generateId();
-
-  let isActive = $derived($selectedIdStore === id);
+  const id = $props.id();
+  const isActive = $derived($selectedIdStore === id);
 
   const handleClick = (event: MouseEvent) => {
     // eslint-disable-next-line unicorn/no-optional-chaining-on-undeclared-variable
diff --git a/web/src/lib/components/shared-components/search-bar/SearchBar.svelte b/web/src/lib/components/shared-components/search-bar/SearchBar.svelte
index cde5fa30b..3742828a3 100644
--- a/web/src/lib/components/shared-components/search-bar/SearchBar.svelte
+++ b/web/src/lib/components/shared-components/search-bar/SearchBar.svelte
@@ -4,7 +4,6 @@
   import { Route } from '#lib/route.ts';
   import { searchStore } from '#lib/stores/search.svelte.ts';
   import { handlePromiseError } from '#lib/utils.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { IconButton } from '@immich/ui';
   import { mdiClose, mdiMagnify } from '@mdi/js';
   import { onDestroy, tick } from 'svelte';
@@ -29,8 +28,7 @@
   let showSuggestions = $state(false);
   let selectedId: string | undefined = $state();
 
-  const listboxId = generateId();
-  const searchTypeId = generateId();
+  const listboxId = $props.id();
 
   onDestroy(() => {
     searchStore.isSearchEnabled = false;
@@ -173,7 +171,6 @@
         aria-activedescendant={selectedId ?? ''}
         aria-expanded={showSuggestions}
         aria-autocomplete="list"
-        aria-describedby={searchTypeId}
         use:shortcuts={[
           { shortcut: { key: 'Escape' }, onShortcut: onEscape },
           { shortcut: { key: 'ArrowUp' }, onShortcut: () => onArrow(-1) },
diff --git a/web/src/lib/components/shared-components/settings/SettingSwitch.svelte b/web/src/lib/components/shared-components/settings/SettingSwitch.svelte
index 51690f354..b35a9c3d5 100644
--- a/web/src/lib/components/shared-components/settings/SettingSwitch.svelte
+++ b/web/src/lib/components/shared-components/settings/SettingSwitch.svelte
@@ -1,12 +1,11 @@
 <script lang="ts">
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { Switch } from '@immich/ui';
   import type { Snippet } from 'svelte';
   import { t } from 'svelte-i18n';
   import { quintOut } from 'svelte/easing';
   import { fly } from 'svelte/transition';
 
-  interface Props {
+  type Props = {
     title: string;
     subtitle?: string;
     checked?: boolean;
@@ -14,7 +13,7 @@
     isEdited?: boolean;
     onToggle?: (isChecked: boolean) => void;
     children?: Snippet;
-  }
+  };
 
   let {
     title,
@@ -26,10 +25,9 @@
     children,
   }: Props = $props();
 
-  let id: string = generateId();
-
-  let switchId = $derived(`input-${id}`);
-  let subtitleId = $derived(subtitle ? `${id}-subtitle` : undefined);
+  const id = $props.id();
+  const switchId = `input-${id}`;
+  const subtitleId = $derived(subtitle ? `${id}-subtitle` : undefined);
 </script>
 
 <div class="flex place-items-center justify-between">
diff --git a/web/src/lib/elements/GroupTab.svelte b/web/src/lib/elements/GroupTab.svelte
index 9e45805eb..8c75174e0 100644
--- a/web/src/lib/elements/GroupTab.svelte
+++ b/web/src/lib/elements/GroupTab.svelte
@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { generateId } from '#lib/utils/generate-id.ts';
-
   interface Props {
     filters: string[];
     labels?: string[];
@@ -9,9 +7,9 @@
     onSelect: (selected: string) => void;
   }
 
-  let { filters, selected, label, labels, onSelect }: Props = $props();
+  const { filters, selected, label, labels, onSelect }: Props = $props();
 
-  const id = `group-tab-${generateId()}`;
+  const id = $props.id();
 </script>
 
 <fieldset
diff --git a/web/src/lib/elements/StarRating.svelte b/web/src/lib/elements/StarRating.svelte
index a81b08988..e38d22f9c 100644
--- a/web/src/lib/elements/StarRating.svelte
+++ b/web/src/lib/elements/StarRating.svelte
@@ -1,28 +1,27 @@
 <script lang="ts">
   import { focusOutside } from '#lib/actions/focus-outside.ts';
   import { shortcuts } from '#lib/actions/shortcut.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { Icon } from '@immich/ui';
   import { mdiStar, mdiStarOutline } from '@mdi/js';
   import { t } from 'svelte-i18n';
 
   export type Rating = -1 | 1 | 2 | 3 | 4 | 5 | null;
 
-  interface Props {
+  type Props = {
     count?: number;
     rating: Rating;
     readOnly?: boolean;
     onRating: (rating: Rating) => void | undefined;
-  }
+  };
 
-  let { count = 5, rating, readOnly = false, onRating }: Props = $props();
+  const { count = 5, rating, readOnly = false, onRating }: Props = $props();
 
   let ratingSelection = $derived(rating);
   let hoverRating: Rating = $state(null);
   let focusRating: Rating = $state(null);
   let timeoutId: ReturnType<typeof setTimeout> | undefined;
 
-  const id = generateId();
+  const id = $props.id();
 
   const handleSelect = (newRating: Rating) => {
     if (readOnly) {
diff --git a/web/src/lib/utils/generate-id.ts b/web/src/lib/utils/generate-id.ts
deleted file mode 100644
index 466be1840..000000000
--- a/web/src/lib/utils/generate-id.ts
+++ /dev/null
@@ -1,2 +0,0 @@
-let _count = 0;
-export const generateId = (): string => `id-${_count++}`;
diff --git a/web/src/routes/(user)/workflows/[workflowId]/+page.svelte b/web/src/routes/(user)/workflows/[workflowId]/+page.svelte
index 982435126..cb25a19d4 100644
--- a/web/src/routes/(user)/workflows/[workflowId]/+page.svelte
+++ b/web/src/routes/(user)/workflows/[workflowId]/+page.svelte
@@ -7,7 +7,6 @@
   import { getWorkflowQuery, updateWorkflowMutation } from '#lib/queries/workflow.query.ts';
   import { Route } from '#lib/route.ts';
   import { getWorkflowActions } from '#lib/services/workflow.service.ts';
-  import { generateId } from '#lib/utils/generate-id.ts';
   import { getTriggerDescription, getTriggerName } from '#lib/utils/workflow.ts';
   import type { WorkflowUpdateDto } from '@immich/sdk';
   import {
@@ -63,6 +62,9 @@
   const query = createPreloadedQuery(() => getWorkflowQuery(params.workflowId));
   const workflow = $derived(query.data);
 
+  let stepCounter = 0;
+  const generateId = () => `step-${stepCounter++}`;
+
   let { id, enabled, name, description, trigger } = $state(query.data);
   let steps = $state(query.data.steps.map((step) => ({ ...step, id: generateId() })));
   const savedWorkflow = $derived(cloneDeep(workflow));