Seperate test steps for positive and negative cases (#5773)

fix php style

use the correct step

fix other steps

fix other php style

remove unwanted param

Refactor test function for handeling errors

fix return types

clean up code

address reviews
This commit is contained in:
Swikriti Tripathi
2023-03-09 16:21:50 +05:45
committed by GitHub
parent d9092d7e17
commit 249adc7cd7
5 changed files with 65 additions and 48 deletions
@@ -136,7 +136,7 @@ Feature: add users to group
Scenario: admin tries to add user to a non-existing group
When the administrator tries to add user "Alice" to group "nonexistentgroup" using the Graph API
When the administrator tries to add user "Alice" to a nonexistent group using the Graph API
Then the HTTP status code should be "404"
@@ -147,7 +147,7 @@ Feature: add users to group
Scenario: admin tries to add user to a group without sending the group
When the administrator tries to add user "Alice" to group "" using the Graph API
When the administrator tries to add user "Alice" to a nonexistent group using the Graph API
Then the HTTP status code should be "404"
@@ -175,7 +175,7 @@ Feature: add users to group
| username |
| Brian |
| Carol |
When the administrator "Alice" tries to add the following users to a non-existing group at once using the Graph API
When the administrator "Alice" tries to add the following users to a nonexistent group at once using the Graph API
| username |
| Brian |
| Carol |
@@ -185,7 +185,7 @@ Feature: add users to group
Scenario: admin tries to add multiple non-existing users to a group at once
Given the administrator has given "Alice" the role "Admin" using the settings api
And user "Alice" has created a group "grp1" using the Graph API
When the administrator "Alice" tries to add the following non-existing users to a group "grp1" at once using the Graph API
When the administrator "Alice" tries to add the following nonexistent users to a group "grp1" at once using the Graph API
| username |
| Brian |
| Carol |
@@ -198,7 +198,7 @@ Feature: add users to group
| username |
| Brian |
And user "Alice" has created a group "grp1" using the Graph API
When the administrator "Alice" tries to add the following users to a group "grp1" at once using the Graph API
When the administrator "Alice" tries to add the following existent and nonexistent users to a group "grp1" at once using the Graph API
| username |
| Brian |
| Carol |