From 1cc94879c27007ddab52788ab7af65d6354497bb Mon Sep 17 00:00:00 2001 From: Viktor Scharf Date: Wed, 26 Feb 2025 11:02:28 +0100 Subject: [PATCH 1/2] static binary issue --- .make/go.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.make/go.mk b/.make/go.mk index c30405282..6d317d269 100644 --- a/.make/go.mk +++ b/.make/go.mk @@ -107,7 +107,7 @@ build: $(BIN)/$(EXECUTABLE) build-debug: $(BIN)/$(EXECUTABLE)-debug $(BIN)/$(EXECUTABLE): $(SOURCES) - $(GOBUILD) -v -tags '$(TAGS)' -ldflags '$(LDFLAGS) $(DOCKER_LDFLAGS)' -o $@ ./cmd/$(NAME) + $(GOBUILD) -v -tags '$(TAGS)' -ldflags '$(LDFLAGS)' -o $@ ./cmd/$(NAME) $(BIN)/$(EXECUTABLE)-debug: $(SOURCES) $(GOBUILD) -v -tags '$(TAGS)' -ldflags '$(DEBUG_LDFLAGS)' -gcflags '$(GCFLAGS)' -o $@ ./cmd/$(NAME) From 71c03e8ae6c12fa1b9f3730a9aaf02328ffc7cb9 Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Wed, 26 Feb 2025 12:48:07 +0100 Subject: [PATCH 2/2] Use 'release-linux-docker-' make target in multiarch Dockerfile --- .make/go.mk | 6 ------ opencloud/docker/Dockerfile.linux.multiarch | 6 ++++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.make/go.mk b/.make/go.mk index 6d317d269..a2cd19001 100644 --- a/.make/go.mk +++ b/.make/go.mk @@ -42,12 +42,6 @@ DEBUG_LDFLAGS += -X google.golang.org/protobuf/reflect/protoregistry.conflictPol DOCKER_LDFLAGS += -X "$(OC_REPO)/pkg/config/defaults.BaseDataPathType=path" -X "$(OC_REPO)/pkg/config/defaults.BaseDataPathValue=/var/lib/opencloud" DOCKER_LDFLAGS += -X "$(OC_REPO)/pkg/config/defaults.BaseConfigPathType=path" -X "$(OC_REPO)/pkg/config/defaults.BaseConfigPathValue=/etc/opencloud" -# We can't link statically when vips is enabled but we still -# prefer static linking where possible -ifndef ENABLE_VIPS - DOCKER_LDFLAGS += -extldflags "-static" -endif - GCFLAGS += all=-N -l .PHONY: all diff --git a/opencloud/docker/Dockerfile.linux.multiarch b/opencloud/docker/Dockerfile.linux.multiarch index 7a04aada9..10f65602d 100644 --- a/opencloud/docker/Dockerfile.linux.multiarch +++ b/opencloud/docker/Dockerfile.linux.multiarch @@ -7,11 +7,13 @@ RUN apk add bash make git curl gcc musl-dev libc-dev binutils-gold inotify-tools COPY ./ /opencloud/ WORKDIR /opencloud/opencloud -RUN GOOS="${TARGETOS:-linux}" GOARCH="${TARGETARCH:-amd64}" make ci-go-generate build ENABLE_VIPS=true +RUN GOOS="${TARGETOS:-linux}" GOARCH="${TARGETARCH:-amd64}" make ci-go-generate release-linux-docker-${TARGETARCH} ENABLE_VIPS=true FROM alpine:3.20 ARG VERSION ARG REVISION +ARG TARGETOS +ARG TARGETARCH RUN apk add --no-cache attr bash ca-certificates curl inotify-tools libc6-compat mailcap tree vips patch && \ echo 'hosts: files dns' >| /etc/nsswitch.conf @@ -48,4 +50,4 @@ EXPOSE 9200/tcp ENTRYPOINT ["/usr/bin/opencloud"] CMD ["server"] -COPY --from=build /opencloud/opencloud/bin/opencloud /usr/bin/opencloud +COPY --from=build /opencloud/opencloud/dist/binaries/opencloud-linux-${TARGETARCH} /usr/bin/opencloud