Remove Staticcheck warnings (#5394)

* remove deprecated ioutil imports

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* remove duplicate imports

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* remove unused values

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* remove some unused types

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* remove deprecated ioutil import

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

ocis-pkg/config/envdecode/envdecode_test.go

@@ -80,7 +80,7 @@ type testConfigOverride struct {
 }
 
 type testNoExportedFields struct {
-	// folowing unexported fields are used for tests
+	// following unexported fields are used for tests
 	aString  string  `env:"TEST_STRING"`  //nolint:structcheck,unused
 	anInt64  int64   `env:"TEST_INT64"`   //nolint:structcheck,unused
 	aUint16  uint16  `env:"TEST_UINT16"`  //nolint:structcheck,unused

ocis-pkg/log/stream.go

@@ -1,24 +0,0 @@
-package log
-
-import (
-	mdlog "go-micro.dev/v4/debug/log"
-)
-
-type logStream struct {
-	stream <-chan mdlog.Record
-	stop   chan bool
-}
-
-func (l *logStream) Chan() <-chan mdlog.Record {
-	return l.stream
-}
-
-func (l *logStream) Stop() error {
-	select {
-	case <-l.stop:
-		return nil
-	default:
-		close(l.stop)
-	}
-	return nil
-}

ocis-pkg/store/store.go

@@ -9,47 +9,37 @@ import (
 	"go-micro.dev/v4/store"
 )
 
-var (
-	storeEnv        = "OCIS_STORE"
-	storeAddressEnv = "OCIS_STORE_ADDRESS"
-	storeOCMemSize  = "OCIS_STORE_OCMEM_SIZE"
-)
-
 var ocMemStore *store.Store
 
 type OcisStoreOptions struct {
-	Type    string
+	// Type determines the implementation:
+	// * "noop", for a noop store (it does nothing)
+	// * "etcd", for etcd
+	// * "ocmem", custom in-memory implementation, with fixed size and optimized prefix
+	// and suffix search
+	// * "memory", for a in-memory implementation, which is the default if noone matches
+	Type string
+
+	// Address is a comma-separated list of nodes that the store
+	// will use. This is currently usable only with the etcd implementation. If it
+	// isn't provided, "127.0.0.1:2379" will be the only node used.
 	Address string
-	Size    int
+
+	// Size configures the maximum capacity of the cache for
+	// the "ocmem" implementation, in number of items that the cache can hold per table.
+	// You can use 5000 to make the cache hold up to 5000 elements.
+	// The parameter only affects to the "ocmem" implementation, the rest will ignore it.
+	// If an invalid value is used, the default of 512 will be used instead.
+	Size int
 }
 
-// Get the configured key-value store to be used.
+// GetStore returns a configured key-value store
 //
 // Each microservice (or whatever piece is using the store) should use the
 // options available in the interface's operations to choose the right database
 // and table to prevent collisions with other microservices.
 // Recommended approach is to use "services" or "ocis-pkg" for the database,
 // and "services/<service-name>/" or "ocis-pkg/<pkg>/" for the package name.
-//
-// So far, only the name of the store and the node addresses are configurable
-// via environment variables.
-// Available options for "OCIS_STORE" are:
-// * "noop", for a noop store (it does nothing)
-// * "etcd", for etcd
-// * "ocmem", custom in-memory implementation, with fixed size and optimized prefix
-// and suffix search
-// * "memory", for a in-memory implementation, which is the default if noone matches
-//
-// "OCIS_STORE_ADDRESS" is a comma-separated list of nodes that the store
-// will use. This is currently usable only with the etcd implementation. If it
-// isn't provided, "127.0.0.1:2379" will be the only node used.
-//
-// "OCIS_STORE_OCMEM_SIZE" will configure the maximum capacity of the cache for
-// the "ocmem" implementation, in number of items that the cache can hold per table.
-// You can use "OCIS_STORE_OCMEM_SIZE=5000" so the cache will hold up to 5000 elements.
-// The parameter only affects to the "ocmem" implementation, the rest will ignore it.
-// If an invalid value is used, the default will be used instead, so up to 512 elements
-// the cache will hold.
 func GetStore(ocisOpts OcisStoreOptions) store.Store {
 	var s store.Store