From 3b9ee2e49f2141b611ba6a2fce7dd8b9a7d27c64 Mon Sep 17 00:00:00 2001 From: pradip Date: Fri, 22 Nov 2024 12:56:15 +0545 Subject: [PATCH] refactor: set chunking version 1 as default --- tests/acceptance/bootstrap/WebDav.php | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/acceptance/bootstrap/WebDav.php b/tests/acceptance/bootstrap/WebDav.php index a2db7fa38..99a625e9b 100644 --- a/tests/acceptance/bootstrap/WebDav.php +++ b/tests/acceptance/bootstrap/WebDav.php @@ -68,8 +68,6 @@ trait WebDav { private int $httpRequestTimeout = 0; - private ?int $chunkingToUse = null; - /** * The ability to do requests with depth infinity is disabled by default. * This remembers when the setting dav.propfind.depth_infinity has been @@ -1636,10 +1634,6 @@ trait WebDav { ?array $headers = [], ?int $noOfChunks = 0 ):void { - $chunkingVersion = $this->chunkingToUse; - if ($noOfChunks <= 0) { - $chunkingVersion = null; - } try { $this->pauseUploadDelete(); $this->response = UploadHelper::upload( @@ -1651,7 +1645,7 @@ trait WebDav { $this->getStepLineRef(), $headers, $this->getDavPathVersion(), - $chunkingVersion, + $noOfChunks <= 0 ? null : 1, $noOfChunks ); $this->lastUploadDeleteTime = \time(); @@ -1686,9 +1680,6 @@ trait WebDav { "What does it mean to have $noOfChunks chunks?" ); - // use chunking version 1 as default, since version 2 uses "remote.php/dav/uploads" endpoint and it doesn't exist in oCIS - $this->chunkingToUse = 1; - if ($async === true) { $headers['OC-LazyOps'] = 'true'; }