Addressed reviews

This commit is contained in:
Prarup Gurung
2024-05-03 09:52:29 +05:45
parent 7423fa3a4b
commit 68f03f2f5e
2 changed files with 1 additions and 5 deletions
@@ -897,7 +897,6 @@ Feature: user GDPR (General Data Protection Regulation) report
"pattern": "^%user_id_pattern%$" "pattern": "^%user_id_pattern%$"
}, },
"type": { "type": {
"type": "number",
"const": 1 "const": 1
} }
} }
@@ -915,13 +914,11 @@ Feature: user GDPR (General Data Protection Regulation) report
"pattern": "^%user_id_pattern%$" "pattern": "^%user_id_pattern%$"
}, },
"type": { "type": {
"type": "number",
"const": 1 "const": 1
} }
} }
}, },
"GranteeGroupID": { "GranteeGroupID": {
"type": ["number", "null"],
"const": null "const": null
}, },
"GranteeUserID": { "GranteeUserID": {
@@ -937,7 +934,6 @@ Feature: user GDPR (General Data Protection Regulation) report
} }
}, },
"type": { "type": {
"type": "string",
"const": "events.SpaceShared" "const": "events.SpaceShared"
} }
} }
@@ -754,7 +754,7 @@ trait Sharing {
$user = $this->getActualUsername($user); $user = $this->getActualUsername($user);
if ($updateLastPublicLink) { if ($updateLastPublicLink) {
$share_id = (FeatureContext::isUsingSharingNG()) ? $this->shareNgGetLastCreatedLinkShareID() : (string) $this->getLastCreatedPublicShare()->id; $share_id = ($this->isUsingSharingNG()) ? $this->shareNgGetLastCreatedLinkShareID() : (string) $this->getLastCreatedPublicShare()->id;
} else { } else {
if ($shareOwner === null) { if ($shareOwner === null) {
$share_id = $this->getLastCreatedUserGroupShareId(); $share_id = $this->getLastCreatedUserGroupShareId();