sevenhill/QSfera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #886 from owncloud/show-basic-auth-warning-on-startup-only

Browse Source 
Show basic_auth warning only on startup
This commit is contained in:
Phil Davis
2020-11-18 19:25:33 +05:45
committed by GitHub
parent bd6b335da0 79e7f85a57
commit a643ad4acd
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changelog/unreleased/dont-nag-about-basicauth.md
+6
View File
@@ -0,0 +1,6 @@
Enhancement: Show basic-auth warning only once
Show basic-auth warning only on startup instead on every request.
https://github.com/owncloud/ocis/pull/886
proxy/pkg/middleware/basic_auth.go
+3 -2
View File
@@ -15,6 +15,9 @@ const publicFilesEndpoint = "/remote.php/dav/public-files/"
// BasicAuth provides a middleware to check if BasicAuth is provided // BasicAuth provides a middleware to check if BasicAuth is provided
func BasicAuth(optionSetters ...Option) func(next http.Handler) http.Handler { func BasicAuth(optionSetters ...Option) func(next http.Handler) http.Handler {
options := newOptions(optionSetters...) options := newOptions(optionSetters...)
if options.EnableBasicAuth {
options.Logger.Warn().Msg("basic auth enabled, use only for testing or development")
}
return func(next http.Handler) http.Handler { return func(next http.Handler) http.Handler {
return &basicAuth{ return &basicAuth{
@@ -41,8 +44,6 @@ func (m basicAuth) ServeHTTP(w http.ResponseWriter, req *http.Request) {
return return
} }
m.logger.Warn().Msg("basic auth enabled, use only for testing or development")
login, password, _ := req.BasicAuth() login, password, _ := req.BasicAuth()
account, status := getAccount(m.logger, m.accountsClient, fmt.Sprintf("login eq '%s' and password eq '%s'", strings.ReplaceAll(login, "'", "''"), strings.ReplaceAll(password, "'", "''"))) account, status := getAccount(m.logger, m.accountsClient, fmt.Sprintf("login eq '%s' and password eq '%s'", strings.ReplaceAll(login, "'", "''"), strings.ReplaceAll(password, "'", "''")))