rework disabling the password policy

services/frontend/README.md

@@ -75,6 +75,8 @@ When setting the `FRONTEND_AUTO_ACCEPT_SHARES` to `true`, all incoming shares wi
 
 Note that the password policy currently impacts only **public link password validation**.
 
+In Infinite Scale, the password policy is always enabled because the max-length restriction is always applying and should be taken into account by the clients.
+
 With the password policy, mandatory criteria for the password can be defined via the environment variables listed below.
 
 Generally, a password can contain any UTF-8 characters, however some characters are regarded as special since they are not used in ordinary texts. Which characters should be treated as special is defined by "The OWASP® Foundation" [password-special-characters](https://owasp.org/www-community/password-special-characters) (between double quotes): " !"#$%&'()*+,-./:;<=>?@[\]^_`{|}~"

services/frontend/pkg/revaconfig/config.go

@@ -25,14 +25,10 @@ func FrontendConfigFromStruct(cfg *config.Config, logger log.Logger) (map[string
 	webURL.Path = path.Join(webURL.Path, "external")
 	webOpenInAppURL := webURL.String()
 
-	var bannedPasswordsList map[string]struct{}
-	if cfg.PasswordPolicy.BannedPasswordsList != "" {
-		bannedPasswordsList, err = readMultilineFile(cfg.PasswordPolicy.BannedPasswordsList)
-		if err != nil {
-			err = fmt.Errorf("failed to load the banned passwords from a file %s: %w", cfg.PasswordPolicy.BannedPasswordsList, err)
-			logger.Err(err).Send()
-			return nil, err
-		}
+	passwordPolicyCfg, err := passwordPolicyConfig(cfg)
+	if err != nil {
+		logger.Err(err).Send()
+		return nil, err
 	}
 
 	archivers := []map[string]interface{}{
@@ -327,16 +323,7 @@ func FrontendConfigFromStruct(cfg *config.Config, logger log.Logger) (map[string
 									},
 								},
 							},
-							"password_policy": map[string]interface{}{
-								"max_characters":           72,
-								"disabled":                 cfg.PasswordPolicy.Disabled,
-								"min_characters":           cfg.PasswordPolicy.MinCharacters,
-								"min_lowercase_characters": cfg.PasswordPolicy.MinLowerCaseCharacters,
-								"min_uppercase_characters": cfg.PasswordPolicy.MinUpperCaseCharacters,
-								"min_digits":               cfg.PasswordPolicy.MinDigits,
-								"min_special_characters":   cfg.PasswordPolicy.MinSpecialCharacters,
-								"banned_passwords_list":    bannedPasswordsList,
-							},
+							"password_policy": passwordPolicyCfg,
 							"notifications": map[string]interface{}{
 								"endpoints": []string{"list", "get", "delete"},
 							},
@@ -385,3 +372,30 @@ func fileExists(path string) bool {
 	}
 	return !info.IsDir()
 }
+
+func passwordPolicyConfig(cfg *config.Config) (map[string]interface{}, error) {
+	_maxCharacters := 72
+	if cfg.PasswordPolicy.Disabled {
+		return map[string]interface{}{
+			"max_characters":        _maxCharacters,
+			"banned_passwords_list": nil,
+		}, nil
+	}
+	var bannedPasswordsList map[string]struct{}
+	var err error
+	if cfg.PasswordPolicy.BannedPasswordsList != "" {
+		bannedPasswordsList, err = readMultilineFile(cfg.PasswordPolicy.BannedPasswordsList)
+		if err != nil {
+			return nil, fmt.Errorf("failed to load the banned passwords from a file %s: %w", cfg.PasswordPolicy.BannedPasswordsList, err)
+		}
+	}
+	return map[string]interface{}{
+		"max_characters":           _maxCharacters,
+		"min_digits":               cfg.PasswordPolicy.MinDigits,
+		"min_characters":           cfg.PasswordPolicy.MinCharacters,
+		"min_lowercase_characters": cfg.PasswordPolicy.MinLowerCaseCharacters,
+		"min_uppercase_characters": cfg.PasswordPolicy.MinUpperCaseCharacters,
+		"min_special_characters":   cfg.PasswordPolicy.MinSpecialCharacters,
+		"banned_passwords_list":    bannedPasswordsList,
+	}, nil
+}