Unskip settings service acceptance tests (#4057)

* Update dependencies, browserslist, linting, acceptance test translations for settings service

* Unskip settings service acceptance tests

* unsilence ci-node-generate steps

* Reset nodejs in CI from 16 to 14

Co-authored-by: Willy Kloucek <wkloucek@owncloud.com>

services/settings/ui/app.js

@@ -4,7 +4,7 @@ import store from './store'
 import translations from './../l10n/translations.json'
 
 // just a dummy function to trick gettext tools
-function $gettext(msg) {
+function $gettext (msg) {
   return msg
 }
 

services/settings/ui/tests/acceptance/helpers/language.js

@@ -2,53 +2,53 @@ const filesMenu = {
   English: [
     'Personal',
     'Shares',
-    'Spaces\nbeta',
+    'Spaces',
     'Deleted files'
   ],
   Deutsch: [
     'Persönlich',
     'Geteilt',
-    'Spaces\nbeta',
+    'Spaces',
     'Gelöschte Dateien'
   ],
   Español: [
     'Personal',
     'Shares',
-    'Spaces\nbeta',
+    'Spaces',
     'Archivos borrados'
   ],
   Français: [
     'Personal',
     'Shares',
-    'Spaces\nbeta',
+    'Spaces',
     'Fichiers supprimés'
   ]
 }
 
 const accountMenu = {
   English: [
-    'N\nnull\nuser1@example.com',
+    'U\nuser1\nuser1@example.org',
     'Settings',
     'Log out',
-    'Personal storage (0.2% used)\n5.06 GB of 2.85 TB used'
+    'Personal storage\n0 B used'
   ],
   Deutsch: [
-    'N\nnull\nuser1@example.com',
+    'U\nuser1\nuser1@example.org',
     'Einstellungen',
     'Abmelden',
-    'Persönlicher Speicher (0.2% benutzt)\n5.06 GB von 2.85 TB benutzt'
+    'Persönlicher Speicherplatz\n0 B verwendet'
   ],
   Español: [
-    'N\nnull\nuser1@example.com',
+    'U\nuser1\nuser1@example.org',
     'Configuración',
     'Salir',
-    'Personal storage (0.2% used)\n5.06 GB of 2.85 TB used'
+    'Personal storage\n0 B used'
   ],
   Français: [
-    'N\nnull\nuser1@example.com',
+    'U\nuser1\nuser1@example.org',
     'Settings',
     'Se déconnecter',
-    'Personal storage (0.2% used)\n5.06 GB of 2.85 TB used'
+    'Personal storage\n0 B used'
   ]
 }
 

services/settings/ui/tests/acceptance/pageobjects/filesPageSettingsContext.js

@@ -14,6 +14,7 @@ module.exports = {
             this.api.elementIdText(item.ELEMENT, res => {
               menu.push(res.value)
             })
+            return undefined
           })
         })
       return menu
@@ -30,6 +31,7 @@ module.exports = {
             this.api.elementIdText(item.ELEMENT, res => {
               menu.push(res.value)
             })
+            return undefined
           })
         })
       await this
@@ -46,6 +48,7 @@ module.exports = {
             this.api.elementIdText(item.ELEMENT, res => {
               menu.push(res.value)
             })
+            return undefined
           })
         })
       return menu

services/settings/ui/tests/acceptance/pageobjects/settingsPage.js

@@ -28,10 +28,10 @@ module.exports = {
 
     getSettingsValue: async function (key) {
       let output
+      let elemfound = true
+
       switch (key) {
         case 'Language':
-          let elemfound = true
-
           // Language value is set to empty at beginning
           // In that case just return false
           await this.api.element('@languageValue', result => {