fix golangci offenses

This commit is contained in:
A.Unger
2020-05-22 10:24:01 +02:00
parent b40048af13
commit c219866c7a
19 changed files with 51 additions and 68 deletions
-5
View File
@@ -11,8 +11,3 @@ func NewInstrument(next Service, metrics *metrics.Metrics) Service {
config: next.config,
}
}
type instrument struct {
next Service
metrics *metrics.Metrics
}
-5
View File
@@ -11,8 +11,3 @@ func NewLogging(next Service, logger log.Logger) Service {
config: next.config,
}
}
type logging struct {
next Service
logger log.Logger
}
+1 -12
View File
@@ -3,8 +3,8 @@ package svc
import (
"net/http"
"github.com/owncloud/ocis-settings/pkg/config"
"github.com/owncloud/ocis-pkg/v2/log"
"github.com/owncloud/ocis-settings/pkg/config"
)
// Option defines a single option function.
@@ -17,17 +17,6 @@ type Options struct {
Middleware []func(http.Handler) http.Handler
}
// newOptions initializes the available default options.
func newOptions(opts ...Option) Options {
opt := Options{}
for _, o := range opts {
o(&opt)
}
return opt
}
// Logger provides a function to set the logger option.
func Logger(val log.Logger) Option {
return func(o *Options) {
+3 -2
View File
@@ -2,6 +2,7 @@ package svc
import (
"context"
"github.com/owncloud/ocis-settings/pkg/settings"
store "github.com/owncloud/ocis-settings/pkg/store/filesystem"
@@ -10,8 +11,8 @@ import (
)
type Service struct {
config *config.Config
manager settings.Manager
config *config.Config
manager settings.Manager
}
// NewService returns a service implementation for Service.
-4
View File
@@ -7,7 +7,3 @@ func NewTracing(next Service) Service {
config: next.config,
}
}
type tracing struct {
next Service
}