sevenhill/QSfera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return BadRequestError instead of InternalServerError

Browse Source 
Apparently InternalServer errors are not returned back by the handler
This commit is contained in:
Ilja Neumann
2020-10-15 18:00:08 +02:00
parent da70231338
commit ca1fa005a6
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
accounts/pkg/service/v0/accounts.go
+5 -4
View File
@@ -319,10 +319,11 @@ func (s Service) CreateAccount(ctx context.Context, in *proto.CreateAccountReque
s.debugLogAccount(acc).Msg("could not persist new account") s.debugLogAccount(acc).Msg("could not persist new account")
return merrors.InternalServerError(s.id, "could not persist new account: %v", err.Error()) return merrors.InternalServerError(s.id, "could not persist new account: %v", err.Error())
} }
indexResults, err2 := s.index.Add(acc) indexResults, err := s.index.Add(acc)
if err2 != nil { if err != nil {
//s.rollbackCreateAccount(ctx, acc) s.rollbackCreateAccount(ctx, acc)
return merrors.InternalServerError(s.id, "could not index new account: %v", err2.Error()) return merrors.BadRequest(s.id, "Account already exists %v", err.Error())
} }
s.log.Debug().Interface("account", acc).Msg("account after indexing") s.log.Debug().Interface("account", acc).Msg("account after indexing")