Removed step and implementation of setting share auto accept

2023-05-08 09:01:54 +05:45
parent 55d72475d7
commit e208b3018a
47 changed files with 50 additions and 114 deletions
@@ -9,8 +9,7 @@ Feature: sharing


  Scenario Outline: creating a share of a file with a user
-    Given auto-accept shares has been disabled
-    And using OCS API version "<ocs_api_version>"
+    Given using OCS API version "<ocs_api_version>"
    And user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt"
    And user "Brian" has been created with default attributes and without skeleton files
@@ -6,7 +6,6 @@ Feature: checksums

  Background:
    Given user "Alice" has been created with default attributes and without skeleton files
-    And auto-accept shares has been disabled
    And using spaces DAV path
    And user "Brian" has been created with default attributes and without skeleton files

@@ -394,17 +394,6 @@ trait Sharing {
 		);
 	}

-	/**
-	 * @Given auto-accept shares has been disabled
-	 *
-	 * @return void
-	 */
-	public function autoAcceptSharesHasBeenDisabled():void {
-		// auto-accept shares is disabled by default on OCIS.
-		// so there is nothing to do, just return
-		return;
-	}
-
 	/**
 	 * @When /^user "([^"]*)" creates a share using the sharing API with settings$/
 	 *
@@ -5,8 +5,7 @@ Feature: favorite
  So that I can access them quickly

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "/PARENT"
    And user "Alice" has uploaded file with content "some data" to "/PARENT/parent.txt"

@@ -177,8 +177,7 @@ Feature: checksums

  @issue-1291
  Scenario Outline: sharing a file with checksum should return the checksum in the propfind using new DAV path
-    Given auto-accept shares has been disabled
-    And using <dav_version> DAV path
+    Given using <dav_version> DAV path
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a"
    And user "Alice" has shared file "/myChecksumFile.txt" with user "Brian"
@@ -192,8 +191,7 @@ Feature: checksums

  @issue-1291
  Scenario Outline: modifying a shared file should return correct checksum in the propfind using new DAV path
-    Given auto-accept shares has been disabled
-    And using <dav_version> DAV path
+    Given using <dav_version> DAV path
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a"
    And user "Alice" has shared file "/myChecksumFile.txt" with user "Brian"
@@ -5,8 +5,7 @@ Feature: Sharing resources with different case names with the sharee and checkin
  So that I can make sure that the shares aren't case sensitive

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: resources shared with the same name are received with unique names
  So that I can make sure the naming is handled properly by the server

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
@@ -5,8 +5,7 @@ Feature: shares are received in the default folder for received shares
  So that I can make sure it does not work

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files


  Scenario Outline: do not allow sharing of the entire share folder
@@ -5,8 +5,7 @@ Feature: sharing works when a username and group name are the same
  So that I can make sure that the sharing works

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files

  @skipOnLDAP
  Scenario: creating a new share with user and a group having same name
@@ -5,8 +5,7 @@ Feature: share resources where the sharee receives the share in multiple ways
  So that I can make sure that the sharing works

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: share resources with a disabled user
  So that I can make sure it doesn't work

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt"

  @issue-2212
@@ -5,8 +5,7 @@ Feature: cannot share resources with invalid permissions
  So that I can make sure it doesn't work

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file with content "some data" to "/textfile0.txt"
    And user "Alice" has created folder "/PARENT"

@@ -5,8 +5,7 @@ Feature: sharing
  So that they can have access on them

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files

  @smokeTest
  Scenario Outline: creating a share of a file with a user, the default permissions are read(1)+update(2)+can-share(16)
@@ -5,8 +5,7 @@ Feature: sharing
  So that I don't have redundant shares

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: accept/decline shares coming from internal users
  So that I can keep my file system clean

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And using new DAV path
    And these users have been created with default attributes and without skeleton files:
      | username |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
@@ -5,8 +5,7 @@ Feature: moving a share inside another share
  So that I have full flexibility when managing resources

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: get the pending shares filtered by type (user, group etc)
  So that I can reduce the amount of data that has to be transferred to be just the data that I need

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: get the received shares filtered by type (user, group etc)
  So that I can reduce the amount of data that has to be transferred to be just the data that I need

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: get the received shares filtered by type (user, group etc)
  So that I can reduce the amount of data that has to be transferred to be just the data that I need

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: get shares filtered by type (user, group etc)
  So that I can reduce the amount of data that has to be transferred to be just the data that I need

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
@@ -2,8 +2,7 @@
 Feature: share access by ID

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files


  Scenario: Uploading file to a user read-only share folder does not work
@@ -2,8 +2,7 @@
 Feature: create a public link share when share_folder is set to Shares

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files


  Scenario Outline: Creating a new public link share of a file gives the correct response
@@ -249,8 +249,7 @@ Feature: update a public link share


  Scenario Outline: Adding public upload to a read only shared folder as recipient is not allowed using the public API
-    Given auto-accept shares has been disabled
-    And using OCS API version "<ocs_api_version>"
+    Given using OCS API version "<ocs_api_version>"
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "/test"
    And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read"
@@ -273,8 +272,7 @@ Feature: update a public link share


  Scenario Outline: Adding public upload to a shared folder as recipient is allowed with permissions using the public API
-    Given auto-accept shares has been disabled
-    And using OCS API version "<ocs_api_version>"
+    Given using OCS API version "<ocs_api_version>"
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "/test"
    And user "Alice" has shared folder "/test" with user "Brian" with permissions "all"
@@ -297,8 +295,7 @@ Feature: update a public link share


  Scenario Outline: Adding public link with all permissions to a read only shared folder as recipient is not allowed using the public API
-    Given auto-accept shares has been disabled
-    And using OCS API version "<ocs_api_version>"
+    Given using OCS API version "<ocs_api_version>"
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "/test"
    And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read"
@@ -321,8 +318,7 @@ Feature: update a public link share


  Scenario Outline: Adding public link with all permissions to a read only shared folder as recipient is allowed with permissions using the public API
-    Given auto-accept shares has been disabled
-    And using OCS API version "<ocs_api_version>"
+    Given using OCS API version "<ocs_api_version>"
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "/test"
    And user "Alice" has shared folder "/test" with user "Brian" with permissions "all"
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: resharing can be done on a reshared resource

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: resharing can be disabled

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: a subfolder of a received share can be reshared

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: resharing a resource with an expiration date

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: sharing

  Background:
-    Given auto-accept shares has been disabled
-    And using OCS API version "1"
+    Given using OCS API version "1"
    And user "Alice" has been created with default attributes and without skeleton files

  @smokeTest
@@ -2,8 +2,7 @@
 Feature: updating shares to users and groups that have the same name

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -2,8 +2,7 @@
 Feature: using trashbin together with sharing

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file with content "file to delete" to "/textfile0.txt"

  @smokeTest
@@ -3,8 +3,7 @@ Feature: independent locks
  Make sure all locks are independent and don't interact with other items that have the same name

  Background:
-    Given auto-accept shares has been disabled
-    And user "Alice" has been created with default attributes and without skeleton files
+    Given user "Alice" has been created with default attributes and without skeleton files
    And user "Brian" has been created with default attributes and without skeleton files


@@ -2,8 +2,7 @@
 Feature: UNLOCK locked items (sharing)

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -79,8 +79,7 @@ Feature: previews of files downloaded through the webdav API


  Scenario: download previews of shared files (to shares folder)
-    Given auto-accept shares has been disabled
-    And user "Brian" has been created with default attributes and without skeleton files
+    Given user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
    And user "Alice" has shared file "/parent.txt" with user "Brian"
    And user "Brian" has accepted share "/parent.txt" offered by user "Alice"
@@ -122,8 +121,7 @@ Feature: previews of files downloaded through the webdav API

  @issue-2538
  Scenario: when owner updates a shared file, previews for sharee are also updated (to shared folder)
-    Given auto-accept shares has been disabled
-    And user "Brian" has been created with default attributes and without skeleton files
+    Given user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
    And user "Alice" has shared file "/parent.txt" with user "Brian"
    And user "Brian" has accepted share "/parent.txt" offered by user "Alice"
@@ -143,8 +141,7 @@ Feature: previews of files downloaded through the webdav API


  Scenario: updates to a file should change the preview for both sharees and sharers
-    Given auto-accept shares has been disabled
-    And user "Brian" has been created with default attributes and without skeleton files
+    Given user "Brian" has been created with default attributes and without skeleton files
    And user "Alice" has created folder "FOLDER"
    And user "Alice" has uploaded file with content "file to upload" to "/FOLDER/lorem.txt"
    And user "Alice" has shared folder "FOLDER" with user "Brian"
@@ -162,8 +159,7 @@ Feature: previews of files downloaded through the webdav API


  Scenario: updates to a group shared file should change the preview for both sharees and sharers
-    Given auto-accept shares has been disabled
-    And group "grp1" has been created
+    Given group "grp1" has been created
    And user "Brian" has been created with default attributes and without skeleton files
    And user "Carol" has been created with default attributes and without skeleton files
    And user "Brian" has been added to group "grp1"
@@ -6,7 +6,6 @@ Feature: copy file

  Background:
    Given using OCS API version "1"
-    And auto-accept shares has been disabled
    And user "Alice" has been created with default attributes and without skeleton files
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt"
    And user "Alice" has uploaded file with content "ownCloud test text file 1" to "/textfile1.txt"
@@ -5,8 +5,7 @@ Feature: create file or folder named similar to Shares folder
  So that I can organise the files in my file system

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -5,8 +5,7 @@ Feature: upload file
  So that I can find files by their real creation date

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |
@@ -3,8 +3,7 @@
 Feature: upload file to shared folder

  Background:
-    Given auto-accept shares has been disabled
-    And these users have been created with default attributes and without skeleton files:
+    Given these users have been created with default attributes and without skeleton files:
      | username |
      | Alice    |
      | Brian    |