From e2441696c26155e286aa42b906009b8c985e0d8c Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Tue, 14 Oct 2025 17:17:08 +0200 Subject: [PATCH] graph(education): 'primaryRole' and 'identities' should be optional Related: #1597 --- .../graph/pkg/service/v0/educationuser.go | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/services/graph/pkg/service/v0/educationuser.go b/services/graph/pkg/service/v0/educationuser.go index 7db38d0ba..ee23e3e2a 100644 --- a/services/graph/pkg/service/v0/educationuser.go +++ b/services/graph/pkg/service/v0/educationuser.go @@ -76,18 +76,7 @@ func (g Graph) PostEducationUser(w http.ResponseWriter, r *http.Request) { return } - identities, ok := u.GetIdentitiesOk() - if !ok { - logger.Debug().Err(err).Interface("user", u).Msg("could not create education user: missing required Collection: 'identities'") - errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest, "missing required Attribute: 'identities'") - return - } - if len(identities) < 1 { - logger.Debug().Err(err).Interface("user", u).Msg("could not create education user: missing entry in Collection: 'identities'") - errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest, "missing required Collection: 'identities'") - return - } - for i, identity := range identities { + for i, identity := range u.GetIdentities() { if _, ok := identity.GetIssuerOk(); !ok { logger.Debug().Err(err).Interface("user", u).Msgf("could not create education user: missing Attribute in 'identities' Collection Entry %d: 'issuer'", i) errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest, fmt.Sprintf("missing Attribute in 'identities' Collection Entry %d: 'issuer'", i)) @@ -130,12 +119,6 @@ func (g Graph) PostEducationUser(w http.ResponseWriter, r *http.Request) { u.SetUserType("Member") } - if _, ok := u.GetPrimaryRoleOk(); !ok { - logger.Debug().Err(err).Interface("user", u).Msg("could not create education user: missing required Attribute: 'primaryRole'") - errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest, "missing required Attribute: 'primaryRole'") - return - } - logger.Debug().Interface("user", u).Msg("calling create education user on backend") if u, err = g.identityEducationBackend.CreateEducationUser(r.Context(), *u); err != nil { logger.Debug().Err(err).Msg("could not create education user: backend error")