From e297142529a12e81aeba37de93c7a7a6aa560346 Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 8 Nov 2021 12:19:26 +0100 Subject: [PATCH] normalize ocs --- ocs/pkg/command/root.go | 23 ++---------- ocs/pkg/command/server.go | 6 +-- ocs/pkg/config/config.go | 51 ++------------------------ ocs/pkg/config/{env.go => mappings.go} | 14 ++++--- 4 files changed, 16 insertions(+), 78 deletions(-) rename ocs/pkg/config/{env.go => mappings.go} (83%) diff --git a/ocs/pkg/command/root.go b/ocs/pkg/command/root.go index eaf26f2e9..5393527b4 100644 --- a/ocs/pkg/command/root.go +++ b/ocs/pkg/command/root.go @@ -73,11 +73,8 @@ func ParseConfig(c *cli.Context, cfg *config.Config) error { // load all env variables relevant to the config in the current context. conf.LoadOSEnv(config.GetEnv(), false) - if err = cfg.UnmapEnv(conf); err != nil { - return err - } - - return nil + bindings := config.StructMappings(cfg) + return ociscfg.BindEnv(conf, bindings) } // SutureService allows for the ocs command to be embedded and supervised by a suture supervisor tree. @@ -87,11 +84,7 @@ type SutureService struct { // NewSutureService creates a new ocs.SutureService func NewSutureService(cfg *ociscfg.Config) suture.Service { - inheritLogging(cfg) - if cfg.Mode == 0 { - cfg.OCS.Supervised = true - } - cfg.OCS.Log.File = cfg.Log.File + cfg.OCS.Log = cfg.Log return SutureService{ cfg: cfg.OCS, } @@ -105,13 +98,3 @@ func (s SutureService) Serve(ctx context.Context) error { return nil } - -// inheritLogging is a poor man's global logging state tip-toeing around circular dependencies. It sets the logging -// of the service to whatever is in the higher config (in this case coming from ocis.yaml) and sets them as defaults, -// being overwritten when the extension parses its config file / env variables. -func inheritLogging(cfg *ociscfg.Config) { - cfg.OCS.Log.File = cfg.Log.File - cfg.OCS.Log.Color = cfg.Log.Color - cfg.OCS.Log.Pretty = cfg.Log.Pretty - cfg.OCS.Log.Level = cfg.Log.Level -} diff --git a/ocs/pkg/command/server.go b/ocs/pkg/command/server.go index 722673cd1..7b3ff6252 100644 --- a/ocs/pkg/command/server.go +++ b/ocs/pkg/command/server.go @@ -26,11 +26,7 @@ func Server(cfg *config.Config) *cli.Command { cfg.HTTP.Root = strings.TrimSuffix(cfg.HTTP.Root, "/") } - if err := ParseConfig(ctx, cfg); err != nil { - return err - } - - return nil + return ParseConfig(ctx, cfg) }, Action: func(c *cli.Context) error { logger := NewLogger(cfg) diff --git a/ocs/pkg/config/config.go b/ocs/pkg/config/config.go index f04c3a311..f2ee415b9 100644 --- a/ocs/pkg/config/config.go +++ b/ocs/pkg/config/config.go @@ -2,20 +2,10 @@ package config import ( "context" - "fmt" - "reflect" - gofig "github.com/gookit/config/v2" + "github.com/owncloud/ocis/ocis-pkg/shared" ) -// Log defines the available logging configuration. -type Log struct { - Level string `mapstructure:"level"` - Pretty bool `mapstructure:"pretty"` - Color bool `mapstructure:"color"` - File string `mapstructure:"file"` -} - // Debug defines the available debug configuration. type Debug struct { Addr string `mapstructure:"addr"` @@ -70,7 +60,7 @@ type IdentityManagement struct { // Config combines all available configuration parts. type Config struct { File string `mapstructure:"file"` - Log Log `mapstructure:"log"` + Log shared.Log `mapstructure:"log"` Debug Debug `mapstructure:"debug"` HTTP HTTP `mapstructure:"http"` Tracing Tracing `mapstructure:"tracing"` @@ -94,7 +84,7 @@ func New() *Config { // DefaultConfig provides default values for a config struct. func DefaultConfig() *Config { return &Config{ - Log: Log{}, + Log: shared.Log{}, Debug: Debug{ Addr: "127.0.0.1:9114", Token: "", @@ -145,38 +135,3 @@ func GetEnv() []string { return r } - -// UnmapEnv loads values from the gooconf.Config argument and sets them in the expected destination. -func (c *Config) UnmapEnv(gooconf *gofig.Config) error { - vals := structMappings(c) - for i := range vals { - for j := range vals[i].EnvVars { - // we need to guard against v != "" because this is the condition that checks that the value is set from the environment. - // the `ok` guard is not enough, apparently. - if v, ok := gooconf.GetValue(vals[i].EnvVars[j]); ok && v != "" { - - // get the destination type from destination - switch reflect.ValueOf(vals[i].Destination).Type().String() { - case "*bool": - r := gooconf.Bool(vals[i].EnvVars[j]) - *vals[i].Destination.(*bool) = r - case "*string": - r := gooconf.String(vals[i].EnvVars[j]) - *vals[i].Destination.(*string) = r - case "*int": - r := gooconf.Int(vals[i].EnvVars[j]) - *vals[i].Destination.(*int) = r - case "*float64": - // defaults to float64 - r := gooconf.Float(vals[i].EnvVars[j]) - *vals[i].Destination.(*float64) = r - default: - // it is unlikely we will ever get here. Let this serve more as a runtime check for when debugging. - return fmt.Errorf("invalid type for env var: `%v`", vals[i].EnvVars[j]) - } - } - } - } - - return nil -} diff --git a/ocs/pkg/config/env.go b/ocs/pkg/config/mappings.go similarity index 83% rename from ocs/pkg/config/env.go rename to ocs/pkg/config/mappings.go index 5ef5ac450..7346ffd98 100644 --- a/ocs/pkg/config/env.go +++ b/ocs/pkg/config/mappings.go @@ -1,13 +1,17 @@ package config -type mapping struct { - EnvVars []string // name of the EnvVars var. - Destination interface{} // memory address of the original config value to modify. +import "github.com/owncloud/ocis/ocis-pkg/shared" + +// StructMappings binds a set of environment variables to a destination on cfg. Iterating over this set and editing the +// Destination value of a binding will alter the original value, as it is a pointer to its memory address. This lets +// us propagate changes easier. +func StructMappings(cfg *Config) []shared.EnvBinding { + return structMappings(cfg) } // structMappings binds a set of environment variables to a destination on cfg. -func structMappings(cfg *Config) []mapping { - return []mapping{ +func structMappings(cfg *Config) []shared.EnvBinding { + return []shared.EnvBinding{ { EnvVars: []string{"OCS_LOG_FILE", "OCIS_LOG_FILE"}, Destination: &cfg.Log.File,