address review

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
This commit is contained in:
Jörn Friedrich Dreyer
2020-07-10 15:51:13 +02:00
parent 0d4e6a4a16
commit ebaf39f0af
4 changed files with 25 additions and 22 deletions
+10 -8
View File
@@ -63,14 +63,14 @@ service GroupsService {
rpc ListGroups(ListGroupsRequest) returns (ListGroupsResponse) {
// List method maps to HTTP GET
option (google.api.http) = {
post: "/api/v0/groups/groups-list",
post: "/api/v0/accounts/groups-list",
body: "*"
};
}
// Gets an groups
rpc GetGroup(GetGroupRequest) returns (Group) {
option (google.api.http) = {
post: "/api/v0/groups/groups-get",
post: "/api/v0/accounts/groups-get",
body: "*"
};
}
@@ -79,7 +79,7 @@ service GroupsService {
// Create maps to HTTP POST. URL path as the collection name.
// HTTP request body contains the resource
option (google.api.http) = {
post: "/api/v0/groups/groups-create"
post: "/api/v0/accounts/groups-create"
body: "*"
};
}
@@ -88,7 +88,7 @@ service GroupsService {
// Update maps to HTTP PATCH. Resource name is mapped to a URL path.
// Resource is contained in the HTTP request body
option (google.api.http) = {
post: "/api/v0/groups/groups-update"
post: "/api/v0/accounts/groups-update"
body: "*"
};
};
@@ -97,7 +97,7 @@ service GroupsService {
// Delete maps to HTTP DELETE. Resource name maps to the URL path.
// There is no request body
option (google.api.http) = {
post: "/api/v0/groups/groups-delete",
post: "/api/v0/accounts/groups-delete",
body: "*"
};
}
@@ -111,7 +111,7 @@ service GroupsService {
rpc AddMember(AddMemberRequest) returns (Group) {
// All request parameters go into body.
option (google.api.http) = {
post: "/v0/groups/{group_id=*}/members/$ref"
post: "/api/v0/groups/{group_id=*}/members/$ref"
body: "*"
};
}
@@ -119,14 +119,16 @@ service GroupsService {
rpc RemoveMember(RemoveMemberRequest) returns (Group) {
// All request parameters go into body.
option (google.api.http) = {
delete: "/v0/groups/{group_id=*}/members/{account_id}/$ref"
delete: "/api/v0/groups/{group_id=*}/members/{account_id}/$ref"
body: "*"
};
}
// group:listmembers https://docs.microsoft.com/en-us/graph/api/group-list-members?view=graph-rest-1.0
rpc ListMembers(ListMembersRequest) returns (ListMembersResponse) {
// All request parameters go into body.
option (google.api.http) = {
get: "/v0/groups/{id=*}/members/$ref"
get: "/api/v0/groups/{id=*}/members/$ref"
body: "*"
};
}