test: allow injection of gateway client in grpc service and add tests

2024-04-17 15:54:51 +02:00
parent 9b4233e690
commit f248d7bba3
4 changed files with 211 additions and 3 deletions
@@ -1,6 +1,7 @@
 package service

 import (
+	gatewayv1beta1 "github.com/cs3org/go-cs3apis/cs3/gateway/v1beta1"
 	"github.com/owncloud/ocis/v2/ocis-pkg/log"
 	"github.com/owncloud/ocis/v2/services/collaboration/pkg/config"
 )
@@ -13,6 +14,7 @@ type Options struct {
 	Logger  log.Logger
 	Config  *config.Config
 	AppURLs map[string]map[string]string
+	Gwc     gatewayv1beta1.GatewayAPIClient
 }

 func newOptions(opts ...Option) Options {
@@ -45,3 +47,10 @@ func AppURLs(val map[string]map[string]string) Option {
 		o.AppURLs = val
 	}
 }
+
+// GatewayAPIClient provides a function to set the GatewayAPIClient option.
+func GatewayAPIClient(val gatewayv1beta1.GatewayAPIClient) Option {
+	return func(o *Options) {
+		o.Gwc = val
+	}
+}
@@ -26,9 +26,13 @@ func NewHandler(opts ...Option) (*Service, func(), error) {
 	teardown := func() {}
 	options := newOptions(opts...)

-	gwc, err := pool.GetGatewayServiceClient(options.Config.CS3Api.Gateway.Name)
-	if err != nil {
-		return nil, teardown, err
+	gwc := options.Gwc
+	var err error
+	if gwc == nil {
+		gwc, err = pool.GetGatewayServiceClient(options.Config.CS3Api.Gateway.Name)
+		if err != nil {
+			return nil, teardown, err
+		}
 	}

 	return &Service{
@@ -0,0 +1,13 @@
+package service_test
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func TestGraph(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Service Suite")
+}
@@ -0,0 +1,182 @@
+package service_test
+
+import (
+	"context"
+	"strconv"
+	"time"
+
+	"github.com/golang-jwt/jwt/v4"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"github.com/stretchr/testify/mock"
+
+	appproviderv1beta1 "github.com/cs3org/go-cs3apis/cs3/app/provider/v1beta1"
+	authpb "github.com/cs3org/go-cs3apis/cs3/auth/provider/v1beta1"
+	gatewayv1beta1 "github.com/cs3org/go-cs3apis/cs3/gateway/v1beta1"
+	userv1beta1 "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1"
+	rpcv1beta1 "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1"
+	providerv1beta1 "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
+	types "github.com/cs3org/go-cs3apis/cs3/types/v1beta1"
+
+	"github.com/cs3org/reva/v2/pkg/rgrpc/status"
+	cs3mocks "github.com/cs3org/reva/v2/tests/cs3mocks/mocks"
+	"github.com/owncloud/ocis/v2/ocis-pkg/log"
+	"github.com/owncloud/ocis/v2/services/collaboration/pkg/config"
+	service "github.com/owncloud/ocis/v2/services/collaboration/pkg/service/grpc/v0"
+)
+
+// Based on https://github.com/cs3org/reva/blob/b99ad4865401144a981d4cfd1ae28b5a018ea51d/pkg/token/manager/jwt/jwt.go#L82
+func MintToken(u *userv1beta1.User, secret string, nowTime time.Time) string {
+	scopes := make(map[string]*authpb.Scope)
+	scopes["user"] = &authpb.Scope{
+		Resource: &types.OpaqueEntry{
+			Decoder: "json",
+			Value:   []byte("{\"Path\":\"/\"}"),
+		},
+		Role: authpb.Role_ROLE_OWNER,
+	}
+
+	claims := jwt.MapClaims{
+		"exp":   nowTime.Add(5 * time.Hour).Unix(),
+		"iss":   "myself",
+		"aud":   "reva",
+		"iat":   nowTime.Unix(),
+		"user":  u,
+		"scope": scopes,
+	}
+	/*
+		claims := claims{
+			StandardClaims: jwt.RegisteredClaims{
+				ExpiresAt: time.Now().Add(5 * time.Hour),
+				Issuer:    "myself",
+				Audience:  "reva",
+				IssuedAt:  time.Now(),
+			},
+			User:  u,
+			Scope: scopes,
+		}
+	*/
+
+	t := jwt.NewWithClaims(jwt.GetSigningMethod("HS256"), claims)
+
+	tkn, _ := t.SignedString([]byte(secret))
+
+	return tkn
+}
+
+var _ = Describe("Discovery", func() {
+	var (
+		cfg           *config.Config
+		gatewayClient *cs3mocks.GatewayAPIClient
+		srv           *service.Service
+		srvTear       func()
+	)
+
+	BeforeEach(func() {
+		cfg = &config.Config{}
+		gatewayClient = &cs3mocks.GatewayAPIClient{}
+
+		srv, srvTear, _ = service.NewHandler(
+			service.Logger(log.NopLogger()),
+			service.Config(cfg),
+			service.AppURLs(map[string]map[string]string{
+				"view": map[string]string{
+					".pdf":  "https://test.server.prv/hosting/wopi/word/view",
+					".djvu": "https://test.server.prv/hosting/wopi/word/view",
+					".docx": "https://test.server.prv/hosting/wopi/word/view",
+					".xls":  "https://test.server.prv/hosting/wopi/cell/view",
+					".xlsb": "https://test.server.prv/hosting/wopi/cell/view",
+				},
+				"edit": map[string]string{
+					".docx": "https://test.server.prv/hosting/wopi/word/edit",
+				},
+			}),
+			service.GatewayAPIClient(gatewayClient),
+		)
+	})
+
+	AfterEach(func() {
+		srvTear()
+	})
+
+	Describe("OpenInApp", func() {
+		It("Invalid access token", func() {
+			ctx := context.Background()
+
+			cfg.HTTP.Addr = "wopiserver.test.prv"
+			cfg.HTTP.Scheme = "https"
+
+			req := &appproviderv1beta1.OpenInAppRequest{
+				ResourceInfo: &providerv1beta1.ResourceInfo{
+					Id: &providerv1beta1.ResourceId{
+						StorageId: "myStorage",
+						OpaqueId:  "storageOpaque001",
+						SpaceId:   "SpaceA",
+					},
+					Path: "/path/to/file",
+				},
+				ViewMode:    appproviderv1beta1.ViewMode_VIEW_MODE_READ_WRITE,
+				AccessToken: "goodAccessToken",
+			}
+
+			gatewayClient.On("WhoAmI", mock.Anything, mock.Anything).Times(1).Return(&gatewayv1beta1.WhoAmIResponse{
+				Status: status.NewOK(ctx),
+				User: &userv1beta1.User{
+					Id: &userv1beta1.UserId{
+						Idp:      "myIdp",
+						OpaqueId: "opaque001",
+						Type:     userv1beta1.UserType_USER_TYPE_PRIMARY,
+					},
+					Username: "username",
+				},
+			}, nil)
+
+			resp, err := srv.OpenInApp(ctx, req)
+			Expect(err).To(HaveOccurred())
+			Expect(resp).To(BeNil())
+		})
+
+		It("Success", func() {
+			ctx := context.Background()
+			nowTime := time.Now()
+
+			cfg.HTTP.Addr = "wopiserver.test.prv"
+			cfg.HTTP.Scheme = "https"
+			cfg.JWTSecret = "my_supa_secret"
+
+			myself := &userv1beta1.User{
+				Id: &userv1beta1.UserId{
+					Idp:      "myIdp",
+					OpaqueId: "opaque001",
+					Type:     userv1beta1.UserType_USER_TYPE_PRIMARY,
+				},
+				Username: "username",
+			}
+
+			req := &appproviderv1beta1.OpenInAppRequest{
+				ResourceInfo: &providerv1beta1.ResourceInfo{
+					Id: &providerv1beta1.ResourceId{
+						StorageId: "myStorage",
+						OpaqueId:  "storageOpaque001",
+						SpaceId:   "SpaceA",
+					},
+					Path: "/path/to/file.docx",
+				},
+				ViewMode:    appproviderv1beta1.ViewMode_VIEW_MODE_READ_WRITE,
+				AccessToken: MintToken(myself, cfg.JWTSecret, nowTime),
+			}
+
+			gatewayClient.On("WhoAmI", mock.Anything, mock.Anything).Times(1).Return(&gatewayv1beta1.WhoAmIResponse{
+				Status: status.NewOK(ctx),
+				User:   myself,
+			}, nil)
+
+			resp, err := srv.OpenInApp(ctx, req)
+			Expect(err).To(Succeed())
+			Expect(resp.GetStatus().GetCode()).To(Equal(rpcv1beta1.Code_CODE_OK))
+			Expect(resp.GetAppUrl().GetMethod()).To(Equal("POST"))
+			Expect(resp.GetAppUrl().GetAppUrl()).To(Equal("https://test.server.prv/hosting/wopi/word/edit?WOPISrc=https%3A%2F%2Fwopiserver.test.prv%2Fwopi%2Ffiles%2F2f6ec18696dd1008106749bd94106e5cfad5c09e15de7b77088d03843e71b43e"))
+			Expect(resp.GetAppUrl().GetFormParameters()["access_token_ttl"]).To(Equal(strconv.FormatInt(nowTime.Add(5*time.Hour).Unix()*1000, 10)))
+		})
+	})
+})