diff --git a/changelog/unreleased/fix-admin-role-assignment.md b/changelog/unreleased/fix-admin-role-assignment.md index 25b2cc84d..30e20f041 100644 --- a/changelog/unreleased/fix-admin-role-assignment.md +++ b/changelog/unreleased/fix-admin-role-assignment.md @@ -3,4 +3,5 @@ Bugfix: Update the admin user role assignment to enforce the config The admin user role assigment was not updated after the first assignment. We now read the assigned role during init and update the admin user ID accordingly if the role is not assigned. This is especially needed when the OCIS_ADMIN_USER_ID is set after the autoprovisioning of the admin user when it originates from an external Identity Provider. +https://github.com/owncloud/ocis/pull/8918 https://github.com/owncloud/ocis/pull/8897 diff --git a/services/settings/pkg/store/metadata/store_test.go b/services/settings/pkg/store/metadata/store_test.go index 0859d38b5..e204618f2 100644 --- a/services/settings/pkg/store/metadata/store_test.go +++ b/services/settings/pkg/store/metadata/store_test.go @@ -2,10 +2,15 @@ package store import ( "context" + "encoding/json" "strings" + "testing" "github.com/cs3org/reva/v2/pkg/errtypes" + . "github.com/onsi/gomega" + settingsmsg "github.com/owncloud/ocis/v2/protogen/gen/ocis/messages/settings/v0" "github.com/owncloud/ocis/v2/services/settings/pkg/config/defaults" + rdefaults "github.com/owncloud/ocis/v2/services/settings/pkg/store/defaults" ) const ( @@ -112,3 +117,74 @@ func (m *MockedMetadataClient) IDExists(id string) bool { func (m *MockedMetadataClient) IDHasContent(id string, content []byte) bool { return string(m.data[id]) == string(content) } + +// TestAdminUserIDInit test the happy path during initialization +func TestAdminUserIDInit(t *testing.T) { + RegisterTestingT(t) + s := &Store{ + cfg: defaults.DefaultConfig(), + } + s.cfg.Bundles = rdefaults.GenerateBundlesDefaultRoles() + s.cfg.AdminUserID = "admin" + + // the first assignment is always happening during the initialisation of the metadata client + err := NewMDC(s) + Expect(err).To(BeNil()) + + assID, err := s.mdc.ReadDir(context.TODO(), accountPath(s.cfg.AdminUserID)) + Expect(len(assID)).To(Equal(1)) + ass, err := s.mdc.SimpleDownload(context.TODO(), assignmentPath(s.cfg.AdminUserID, assID[0])) + Expect(ass).ToNot(BeNil()) + + assignment := &settingsmsg.UserRoleAssignment{} + err = json.Unmarshal(ass, assignment) + Expect(err).To(BeNil()) + Expect(assignment.RoleId).To(Equal(rdefaults.BundleUUIDRoleAdmin)) +} + +// TestAdminUserIDUpdate test the update on following initialisations +func TestAdminUserIDUpdate(t *testing.T) { + RegisterTestingT(t) + s := &Store{ + cfg: defaults.DefaultConfig(), + } + s.cfg.Bundles = rdefaults.GenerateBundlesDefaultRoles() + s.cfg.AdminUserID = "admin" + + // the first assignment is always happening during the initialisation of the metadata client + err := NewMDC(s) + Expect(err).To(BeNil()) + + // read assignment + assID, err := s.mdc.ReadDir(context.TODO(), accountPath(s.cfg.AdminUserID)) + Expect(len(assID)).To(Equal(1)) + + // set assignment to user role + userRoleAssignment := &settingsmsg.UserRoleAssignment{ + AccountUuid: s.cfg.AdminUserID, + RoleId: rdefaults.BundleUUIDRoleUser, + } + b, err := json.Marshal(userRoleAssignment) + err = s.mdc.Delete(context.TODO(), assignmentPath(s.cfg.AdminUserID, assID[0])) + Expect(err).To(BeNil()) + err = s.mdc.SimpleUpload(context.TODO(), assignmentPath(s.cfg.AdminUserID, assID[0]), b) + Expect(err).To(BeNil()) + + // this happens on every Read / Write on the store + // the actual init is only done if the metadata client has not been initialized before + // this normally needs a restart of the service + err = s.initMetadataClient(s.mdc) + Expect(err).To(BeNil()) + + // read assignment id, changes every time the assignment is written + assID, err = s.mdc.ReadDir(context.TODO(), accountPath(s.cfg.AdminUserID)) + Expect(len(assID)).To(Equal(1)) + + // check if the assignment is the admin role again + ass, err := s.mdc.SimpleDownload(context.TODO(), assignmentPath(s.cfg.AdminUserID, assID[0])) + Expect(ass).ToNot(BeNil()) + assignment := &settingsmsg.UserRoleAssignment{} + err = json.Unmarshal(ass, assignment) + Expect(err).To(BeNil()) + Expect(assignment.RoleId).To(Equal(rdefaults.BundleUUIDRoleAdmin)) +}