sevenhill/QSfera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2784 from owncloud/php-types-check

Browse Source 
[Tests-Only][full-ci] enforce strict type checking for php api tests
This commit is contained in:
Phil Davis
2021-11-29 13:53:34 +05:45
committed by GitHub
parent a7dc0ce196 f8b0f69dd0
commit f5bbdbe1eb
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/acceptance/features/bootstrap/ArchiverContext.php
+2 -2
View File
@@ -1,4 +1,4 @@
<?php <?php declare(strict_types=1);
/** /**
* ownCloud * ownCloud
* *
@@ -207,7 +207,7 @@ class ArchiverContext implements Context {
* *
* @throws Exception * @throws Exception
*/ */
public function theDownloadedArchiveShouldContainTheseFiles(string $type, TableNode $expectedFiles) { public function theDownloadedArchiveShouldContainTheseFiles(string $type, TableNode $expectedFiles):void {
$this->featureContext->verifyTableNodeColumns($expectedFiles, ['name', 'content']); $this->featureContext->verifyTableNodeColumns($expectedFiles, ['name', 'content']);
$tempFile = \tempnam(\sys_get_temp_dir(), 'OcAcceptanceTests_'); $tempFile = \tempnam(\sys_get_temp_dir(), 'OcAcceptanceTests_');
\unlink($tempFile); // we only need the name \unlink($tempFile); // we only need the name
tests/acceptance/features/bootstrap/RevaContext.php
+1 -1
View File
@@ -1,4 +1,4 @@
<?php <?php declare(strict_types=1);
/** /**
* ownCloud * ownCloud
* *
tests/acceptance/features/bootstrap/SpacesContext.php
+2 -2
View File
@@ -1,4 +1,4 @@
<?php <?php declare(strict_types=1);
/** /**
* ownCloud * ownCloud
* *
@@ -163,7 +163,7 @@ class SpacesContext implements Context {
* @throws Exception * @throws Exception
*/ */
public function getSpaceByNameFromResponse(string $name): array { public function getSpaceByNameFromResponse(string $name): array {
$response = json_decode($this->featureContext->getResponse()->getBody(), true, 512, JSON_THROW_ON_ERROR); $response = json_decode((string)$this->featureContext->getResponse()->getBody(), true, 512, JSON_THROW_ON_ERROR);
$spaceAsArray = $response; $spaceAsArray = $response;
if (isset($response['name']) && $response['name'] === $name) { if (isset($response['name']) && $response['name'] === $name) {
return $response; return $response;
tests/acceptance/features/bootstrap/bootstrap.php
+1 -1
View File
@@ -1,4 +1,4 @@
<?php <?php declare(strict_types=1);
/** /**
* ownCloud * ownCloud
* *