refactor middlewares and reduce technical complexity

restructure server command and remove cfg.OIDC.Issuer switch, oidc middleware detects now if it should used or not
fix #761

proxy/pkg/middleware/oidc_auth_test.go

@@ -0,0 +1,68 @@
+package middleware
+
+import (
+	"context"
+	"fmt"
+	"github.com/coreos/go-oidc"
+	"github.com/owncloud/ocis/ocis-pkg/log"
+	"golang.org/x/oauth2"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func TestOIDCAuthMiddleware(t *testing.T) {
+	svcCache.Invalidate(AccountsKey, "success")
+
+	next := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})
+
+	m := OIDCAuth(
+		Logger(log.NewLogger()),
+		OIDCProviderFunc(func() (OIDCProvider, error) {
+			return mockOP(false), nil
+		}),
+		OIDCIss("https://localhost:9200"),
+	)(next)
+
+	r := httptest.NewRequest(http.MethodGet, "https://idp.example.com", nil)
+	r.Header.Set("Authorization", "Bearer sometoken")
+	w := httptest.NewRecorder()
+	m.ServeHTTP(w, r)
+
+	if w.Code != http.StatusInternalServerError {
+		t.Errorf("expected an internal server error")
+	}
+}
+
+type mockOIDCProvider struct {
+	UserInfoFunc func(ctx context.Context, ts oauth2.TokenSource) (*oidc.UserInfo, error)
+}
+
+// UserInfo will panic if the function has been called, but not mocked
+func (m mockOIDCProvider) UserInfo(ctx context.Context, ts oauth2.TokenSource) (*oidc.UserInfo, error) {
+	if m.UserInfoFunc != nil {
+		return m.UserInfoFunc(ctx, ts)
+	}
+
+	panic("UserInfo was called in test but not mocked")
+}
+
+func mockOP(retErr bool) OIDCProvider {
+	if retErr {
+		return &mockOIDCProvider{
+			UserInfoFunc: func(ctx context.Context, ts oauth2.TokenSource) (*oidc.UserInfo, error) {
+				return nil, fmt.Errorf("error returned by mockOIDCProvider UserInfo")
+			},
+		}
+
+	}
+	return &mockOIDCProvider{
+		UserInfoFunc: func(ctx context.Context, ts oauth2.TokenSource) (*oidc.UserInfo, error) {
+			ui := &oidc.UserInfo{
+				// claims: private ...
+			}
+			return ui, nil
+		},
+	}
+
+}