From fd5e371ee1cb7564935b8dd5d8dc793c0260a498 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Thu, 23 Jul 2020 13:32:15 +0200 Subject: [PATCH] Bugfix: ignore case when comparing objectclass values MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Friedrich Dreyer --- changelog/unreleased/ignore-case-for-objectclass-value.md | 5 +++++ pkg/server/glauth/handler.go | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelog/unreleased/ignore-case-for-objectclass-value.md diff --git a/changelog/unreleased/ignore-case-for-objectclass-value.md b/changelog/unreleased/ignore-case-for-objectclass-value.md new file mode 100644 index 000000000..00d6219f4 --- /dev/null +++ b/changelog/unreleased/ignore-case-for-objectclass-value.md @@ -0,0 +1,5 @@ +Bugfix: ignore case when comparing objectclass values + +The LDAP equality comparison is specified as case insensitive. We fixed the comparison for objectclass properties. + +https://github.com/owncloud/ocis-glauth/pull/26 diff --git a/pkg/server/glauth/handler.go b/pkg/server/glauth/handler.go index dad7b3e47..2dbe23b36 100644 --- a/pkg/server/glauth/handler.go +++ b/pkg/server/glauth/handler.go @@ -305,7 +305,7 @@ func parseFilter(f *ber.Packet) (qtype queryType, q string, err error) { // replace attributes switch attribute { case "objectclass": - switch value { + switch strings.ToLower(value) { case "posixaccount", "shadowaccount", "users", "person", "inetorgperson", "organizationalperson": qtype = usersQuery case "posixgroup", "groups":