Ralf HaferkampandRalf Haferkamp
c9a9fddef1
We were using stretchr/testify and test-go/testify inconsitently and sometimes mixed in the same tests. This can cause very strange issue, e.g when using things like mock.MatchedBy(). This moves all our code to stretchr/testify, which seems to be far more active and maintained then test-go/testify.
237 lines
7.1 KiB
Go
237 lines
7.1 KiB
Go
package svc
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/owncloud/ocis/v2/ocis-pkg/middleware"
|
|
settingsmsg "github.com/owncloud/ocis/v2/protogen/gen/ocis/messages/settings/v0"
|
|
v0 "github.com/owncloud/ocis/v2/protogen/gen/ocis/services/settings/v0"
|
|
"github.com/owncloud/ocis/v2/services/settings/pkg/settings/mocks"
|
|
"github.com/owncloud/ocis/v2/services/settings/pkg/store/defaults"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
merrors "go-micro.dev/v4/errors"
|
|
"go-micro.dev/v4/metadata"
|
|
)
|
|
|
|
var (
|
|
ctxWithUUID = metadata.Set(context.Background(), middleware.AccountID, "61445573-4dbe-4d56-88dc-88ab47aceba7")
|
|
ctxWithEmptyUUID = metadata.Set(context.Background(), middleware.AccountID, "")
|
|
emptyCtx = context.Background()
|
|
|
|
scenarios = []struct {
|
|
name string
|
|
accountUUID string
|
|
ctx context.Context
|
|
expect string
|
|
}{
|
|
{
|
|
name: "context with UUID; identifier = 'me'",
|
|
ctx: ctxWithUUID,
|
|
accountUUID: "me",
|
|
expect: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
},
|
|
{
|
|
name: "context with empty UUID; identifier = 'me'",
|
|
ctx: ctxWithEmptyUUID,
|
|
accountUUID: "me",
|
|
expect: "",
|
|
},
|
|
{
|
|
name: "context without UUID; identifier = 'me'",
|
|
ctx: emptyCtx,
|
|
accountUUID: "me",
|
|
expect: "",
|
|
},
|
|
{
|
|
name: "context with UUID; identifier not 'me'",
|
|
ctx: ctxWithUUID,
|
|
accountUUID: "",
|
|
expect: "",
|
|
},
|
|
}
|
|
)
|
|
|
|
func TestGetValidatedAccountUUID(t *testing.T) {
|
|
for _, s := range scenarios {
|
|
scenario := s
|
|
t.Run(scenario.name, func(t *testing.T) {
|
|
got := getValidatedAccountUUID(scenario.ctx, scenario.accountUUID)
|
|
assert.NotPanics(t, func() {
|
|
getValidatedAccountUUID(emptyCtx, scenario.accountUUID)
|
|
})
|
|
assert.Equal(t, scenario.expect, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestEditOwnRoleAssignment(t *testing.T) {
|
|
manager := &mocks.Manager{}
|
|
svc := Service{
|
|
manager: manager,
|
|
}
|
|
a := []*settingsmsg.UserRoleAssignment{}
|
|
manager.On("ListRoleAssignments", mock.Anything).Return(a, nil)
|
|
manager.On("WriteRoleAssignment", mock.Anything, mock.Anything).Return(nil, nil)
|
|
// Creating an initial self assignment is expected to succeed for UserRole when no assignment exists yet
|
|
req := v0.AssignRoleToUserRequest{
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: defaults.BundleUUIDRoleUser,
|
|
}
|
|
res := v0.AssignRoleToUserResponse{}
|
|
err := svc.AssignRoleToUser(ctxWithUUID, &req, &res)
|
|
assert.Nil(t, err)
|
|
|
|
// Creating an initial self assignment is expected to fail for non UserRole when no assignment exists yet
|
|
req = v0.AssignRoleToUserRequest{
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: defaults.BundleUUIDRoleAdmin,
|
|
}
|
|
res = v0.AssignRoleToUserResponse{}
|
|
err = svc.AssignRoleToUser(ctxWithUUID, &req, &res)
|
|
assert.NotNil(t, err)
|
|
|
|
manager = &mocks.Manager{}
|
|
svc = Service{
|
|
manager: manager,
|
|
}
|
|
a = []*settingsmsg.UserRoleAssignment{
|
|
{
|
|
Id: "00000000-0000-0000-0000-000000000001",
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: "aceb15b8-7486-479f-ae32-c91118e07a39",
|
|
},
|
|
}
|
|
editRolePermission := &settingsmsg.Permission{
|
|
Operation: settingsmsg.Permission_OPERATION_READWRITE,
|
|
Constraint: settingsmsg.Permission_CONSTRAINT_ALL,
|
|
}
|
|
manager.On("ListRoleAssignments", mock.Anything).Return(a, nil)
|
|
manager.On("ReadPermissionByID", mock.Anything, mock.Anything).Return(editRolePermission, nil)
|
|
|
|
// Creating an self assignment is expect to fail if there is already an assingment
|
|
req = v0.AssignRoleToUserRequest{
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: defaults.BundleUUIDRoleUser,
|
|
}
|
|
res = v0.AssignRoleToUserResponse{}
|
|
err = svc.AssignRoleToUser(ctxWithUUID, &req, &res)
|
|
assert.NotNil(t, err)
|
|
|
|
manager.On("WriteRoleAssignment", mock.Anything, mock.Anything).Return(nil, nil)
|
|
// Creating an assignment for somebody else is expected to succeed, give the right permissions
|
|
req = v0.AssignRoleToUserRequest{
|
|
AccountUuid: "00000000-0000-0000-0000-000000000000",
|
|
RoleId: "aceb15b8-7486-479f-ae32-c91118e07a39",
|
|
}
|
|
res = v0.AssignRoleToUserResponse{}
|
|
err = svc.AssignRoleToUser(ctxWithUUID, &req, &res)
|
|
assert.Nil(t, err)
|
|
}
|
|
|
|
func TestRemoveOwnRoleAssignment(t *testing.T) {
|
|
manager := &mocks.Manager{}
|
|
a := []*settingsmsg.UserRoleAssignment{
|
|
{
|
|
Id: "00000000-0000-0000-0000-000000000001",
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: "aceb15b8-7486-479f-ae32-c91118e07a39",
|
|
},
|
|
}
|
|
editRolePermission := &settingsmsg.Permission{
|
|
Operation: settingsmsg.Permission_OPERATION_READWRITE,
|
|
Constraint: settingsmsg.Permission_CONSTRAINT_ALL,
|
|
}
|
|
manager.On("ReadPermissionByID", mock.Anything, mock.Anything).Return(editRolePermission, nil)
|
|
manager.On("ListRoleAssignments", mock.Anything).Return(a, nil)
|
|
svc := Service{
|
|
manager: manager,
|
|
}
|
|
|
|
// Removing a role for oneself is expected to fail
|
|
req := v0.RemoveRoleFromUserRequest{
|
|
Id: "00000000-0000-0000-0000-000000000001",
|
|
}
|
|
err := svc.RemoveRoleFromUser(ctxWithUUID, &req, nil)
|
|
assert.NotNil(t, err)
|
|
|
|
manager = &mocks.Manager{}
|
|
manager.On("ListRoleAssignments", mock.Anything).Return(nil, nil)
|
|
manager.On("RemoveRoleAssignment", mock.Anything).Return(nil)
|
|
manager.On("ReadPermissionByID", mock.Anything, mock.Anything).Return(editRolePermission, nil)
|
|
svc = Service{
|
|
manager: manager,
|
|
}
|
|
// Removing a role for someone else is expected to fail
|
|
req = v0.RemoveRoleFromUserRequest{
|
|
Id: "00000000-0000-0000-0000-000000000002",
|
|
}
|
|
err = svc.RemoveRoleFromUser(ctxWithUUID, &req, nil)
|
|
assert.Nil(t, err)
|
|
}
|
|
|
|
func TestListPermissionsOfCurrentUser(t *testing.T) {
|
|
manager := &mocks.Manager{}
|
|
a := []*settingsmsg.UserRoleAssignment{
|
|
{
|
|
Id: "00000000-0000-0000-0000-000000000001",
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
RoleId: "aceb15b8-7486-479f-ae32-c91118e07a39",
|
|
},
|
|
}
|
|
manager.On("ListRoleAssignments", mock.Anything).Return(a, nil)
|
|
b := &settingsmsg.Bundle{
|
|
Id: "aceb15b8-7486-479f-ae32-c91118e07a39",
|
|
Settings: []*settingsmsg.Setting{
|
|
{
|
|
Name: "some-permission",
|
|
},
|
|
{
|
|
Name: "other-permission",
|
|
},
|
|
{
|
|
Name: "duplicate-permission",
|
|
},
|
|
{
|
|
Name: "duplicate-permission",
|
|
},
|
|
},
|
|
}
|
|
manager.On("ReadBundle", mock.Anything).Return(b, nil)
|
|
svc := Service{
|
|
manager: manager,
|
|
}
|
|
|
|
// Listing permissions for yourself
|
|
req := v0.ListPermissionsRequest{
|
|
AccountUuid: "61445573-4dbe-4d56-88dc-88ab47aceba7",
|
|
}
|
|
res := v0.ListPermissionsResponse{}
|
|
err := svc.ListPermissions(ctxWithUUID, &req, &res)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, res.Permissions, 3)
|
|
}
|
|
|
|
func TestListPermissionsOfOtherUser(t *testing.T) {
|
|
manager := &mocks.Manager{}
|
|
svc := Service{
|
|
manager: manager,
|
|
}
|
|
|
|
// Listing permissions for another user produces a not found error
|
|
req := v0.ListPermissionsRequest{
|
|
AccountUuid: "66666666-4444-4444-8888-88ab47aceba7",
|
|
}
|
|
res := v0.ListPermissionsResponse{}
|
|
err := svc.ListPermissions(ctxWithUUID, &req, &res)
|
|
assert.Error(t, err)
|
|
|
|
// assert the requested account uuid was not found
|
|
merr, ok := merrors.As(err)
|
|
assert.True(t, ok)
|
|
assert.Equal(t, int32(http.StatusNotFound), merr.Code)
|
|
assert.Contains(t, err.Error(), req.AccountUuid)
|
|
}
|