sevenhill/QSfera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[tests-only] Retry listing roles if the response body is invalid (#7735)

Browse Source 
* retry listing roles if the response body is invalid

* fix php style

* reset tryAgain
This commit is contained in:
Sawjan Gurung
2023-11-21 18:29:19 +05:45
committed by GitHub
parent 279d0f8563
commit da390e8f12
1 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/acceptance/features/bootstrap/SettingsContext.php
+31 -8
View File
@@ -153,15 +153,38 @@ class SettingsContext implements Context {
* @return string
*/
public function getRoleIdByRoleName(string $user, string $role): string {
$response = $this->getRoles($user);
$this->featureContext->theHTTPStatusCodeShouldBe(
201,
"Expected response status code should be 201",
$response
);
// Sometimes the response body is not complete and results invalid json.
// so we try again until we get a valid json.
$tryAgain = false;
$retried = 0;
do {
$response = $this->getRoles($user);
$this->featureContext->theHTTPStatusCodeShouldBe(
201,
"Expected response status code should be 201",
$response
);
$rawBody = $response->getBody()->getContents();
try {
$decodedBody = \json_decode($rawBody, true, 512, JSON_THROW_ON_ERROR);
$tryAgain = false;
} catch (Exception $e) {
$tryAgain = $retried < HttpRequestHelper::numRetriesOnHttpTooEarly();
if (!$tryAgain) {
throw $e;
}
}
if ($tryAgain) {
$retried += 1;
echo "Invalid json body, retrying ($retried)...\n";
// wait 500ms and try again
\usleep(500 * 1000);
}
} while ($tryAgain);
$rawBody = $response->getBody()->getContents();
$decodedBody = \json_decode($rawBody, true, 512, JSON_THROW_ON_ERROR);
Assert::assertArrayHasKey(
'bundles',
$decodedBody,