Merge pull request #9191 from owncloud/use-sharingNG-in-coreApiShareOperationsToShares2

[tests-only] [full-ci] Use sharingNG in coreApiShareOperationsToShares2

tests/acceptance/config/behat-core.yml

@@ -128,6 +128,7 @@ default:
         - PublicWebDavContext:
         - TrashbinContext:
         - WebDavPropertiesContext:
+        - SharingNgContext:
 
     coreApiSharePublicLink1:
       paths:

tests/acceptance/expected-failures-API-on-OCIS-storage.md

@@ -304,16 +304,16 @@ And other missing implementation of favorites
 - [coreApiShareOperationsToShares2/shareAccessByID.feature:90](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L90)
 - [coreApiShareOperationsToShares2/shareAccessByID.feature:101](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L101)
 - [coreApiShareOperationsToShares2/shareAccessByID.feature:102](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L102)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:131](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L131)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:132](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L132)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:133](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L133)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:134](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L134)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:135](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L135)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:136](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L136)
 - [coreApiShareOperationsToShares2/shareAccessByID.feature:137](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L137)
 - [coreApiShareOperationsToShares2/shareAccessByID.feature:138](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L138)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:149](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L149)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:150](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L150)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:139](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L139)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:140](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L140)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:141](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L141)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:142](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L142)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:143](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L143)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L144)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:155](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L155)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:156](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L156)
 
 #### [Shares to deleted group listed in the response](https://github.com/owncloud/ocis/issues/2441)
 
@@ -370,8 +370,8 @@ Not everything needs to be implemented for ocis. While the oc10 testsuite covers
 - [coreApiShareManagementToShares/acceptShares.feature:190](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L190)
 - [coreApiShareManagementToShares/acceptShares.feature:238](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L238)
 - [coreApiShareManagementToShares/acceptShares.feature:457](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L457)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:119](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L119)
-- [coreApiShareOperationsToShares2/shareAccessByID.feature:120](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L120)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:125](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L125)
+- [coreApiShareOperationsToShares2/shareAccessByID.feature:126](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L126)
 - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:213](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L213)
 - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:214](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L214)
 - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:215](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L215)

tests/acceptance/features/coreApiShareOperationsToShares2/getWebDAVSharePermissions.feature

@@ -34,7 +34,12 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received file with edit
     Given using <dav-path-version> DAV path
     And user "Alice" has uploaded file with content "foo" to "/tmp.txt"
-    And user "Alice" has shared file "/tmp.txt" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp.txt     |
+      | space           | Personal    |
+      | sharee          | Brian       |
+      | shareType       | user        |
+      | permissionsRole | File Editor |
     When user "Brian" gets the following properties of file "/Shares/tmp.txt" using the WebDAV API
       | propertyName          |
       | ocs:share-permissions |
@@ -70,7 +75,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received file with edit permissions but no reshare permissions
     Given using <dav-path-version> DAV path
     And user "Alice" has uploaded file with content "foo" to "/tmp.txt"
-    And user "Alice" has shared file "tmp.txt" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp.txt  |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | update,read |
     Then the HTTP status code should be "200"
@@ -105,7 +116,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received file without edit permissions
     Given using <dav-path-version> DAV path
     And user "Alice" has uploaded file with content "foo" to "/tmp.txt"
-    And user "Alice" has shared file "tmp.txt" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp.txt  |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | read |
     Then the HTTP status code should be "200"
@@ -159,7 +176,12 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received folder with all permissions
     Given using <dav-path-version> DAV path
     And user "Alice" has created folder "/tmp"
-    And user "Alice" has shared file "/tmp" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp      |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Editor   |
     When user "Brian" gets the following properties of folder "/Shares/tmp" using the WebDAV API
       | propertyName          |
       | ocs:share-permissions |
@@ -194,7 +216,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received folder with all permissions but edit
     Given using <dav-path-version> DAV path
     And user "Alice" has created folder "/tmp"
-    And user "Alice" has shared file "/tmp" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp      |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | delete,create,read |
     Then the HTTP status code should be "200"
@@ -229,7 +257,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received folder with all permissions but create
     Given using <dav-path-version> DAV path
     And user "Alice" has created folder "/tmp"
-    And user "Alice" has shared file "/tmp" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp      |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | delete,update,read |
     Then the HTTP status code should be "200"
@@ -264,7 +298,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received folder with all permissions but delete
     Given using <dav-path-version> DAV path
     And user "Alice" has created folder "/tmp"
-    And user "Alice" has shared file "/tmp" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp      |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | create,update,read |
     Then the HTTP status code should be "200"
@@ -299,7 +339,13 @@ Feature: sharing
   Scenario Outline: check webdav share-permissions for received folder with all permissions but share
     Given using <dav-path-version> DAV path
     And user "Alice" has created folder "/tmp"
-    And user "Alice" has shared file "/tmp" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | tmp      |
+      | space           | Personal |
+      | sharee          | Brian    |
+      | shareType       | user     |
+      | permissionsRole | Viewer   |
+    And using SharingNG
     When user "Alice" updates the last share using the sharing API with
       | permissions | change |
     Then the HTTP status code should be "200"

tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature

@@ -105,7 +105,13 @@ Feature: share access by ID
   Scenario Outline: decline a share using the share Id
     Given using OCS API version "<ocs-api-version>"
     And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt"
-    And user "Alice" has shared file "textfile0.txt" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | textfile0.txt |
+      | space           | Personal      |
+      | sharee          | Brian         |
+      | shareType       | user          |
+      | permissionsRole | File Editor   |
+    And using SharingNG
     When user "Brian" declines share with ID "%last_share_id%" using the sharing API
     Then the OCS status code should be "<ocs-status-code>"
     And the HTTP status code should be "200"

tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature

@@ -146,7 +146,12 @@ Feature: sharing
     And user "Brian" has been created with default attributes and without skeleton files
     And user "Admin" has changed the quota of the personal space of "Brian Murphy" space to "0"
     And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/myfile.txt"
-    And user "Alice" has shared file "myfile.txt" with user "Brian"
+    And user "Alice" has sent the following resource share invitation:
+      | resource        | myfile.txt  |
+      | space           | Personal    |
+      | sharee          | Brian       |
+      | shareType       | user        |
+      | permissionsRole | File Editor |
     When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/myfile.txt" using the WebDAV API
     Then the HTTP status code should be "204"
     And the following headers should match these regular expressions for user "Brian"
@@ -266,7 +271,12 @@ Feature: sharing
     Given using <dav-path-version> DAV path
     And user "Brian" has been created with default attributes and without skeleton files
     And user "Brian" has created folder "/folder-to-share"
-    And user "Brian" has shared folder "/folder-to-share" with user "Alice"
+    And user "Brian" has sent the following resource share invitation:
+      | resource        | folder-to-share |
+      | space           | Personal |
+      | sharee          | Alice    |
+      | shareType       | user     |
+      | permissionsRole | Editor   |
     When user "Alice" uploads file "filesForUpload/zerobyte.txt" to "/Shares/folder-to-share/zerobyte.txt" using the WebDAV API
     Then the HTTP status code should be "201"
     And as "Alice" file "/Shares/folder-to-share/zerobyte.txt" should exist